You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/20 11:51:00 UTC
[jira] [Work logged] (IMAGING-243) PNG Writer Indexed Color with
semi-transparent Pixels and Better Compression
[ https://issues.apache.org/jira/browse/IMAGING-243?focusedWorklogId=346647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346647 ]
ASF GitHub Bot logged work on IMAGING-243:
------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/19 11:50
Start Date: 20/Nov/19 11:50
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #58: [IMAGING-243] PNG Writer Indexed Color with semi-transparent Pixels and Better Compression
URL: https://github.com/apache/commons-imaging/pull/58#discussion_r348437846
##########
File path: src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
##########
@@ -596,8 +588,10 @@ public void writeImage(final BufferedImage src, final OutputStream os, Map<Strin
// Debug.debug("uncompressed", uncompressed.length);
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
- final DeflaterOutputStream dos = new DeflaterOutputStream(baos);
final int chunkSize = 256 * 1024;
+ Deflater deflater = new Deflater(Deflater.BEST_COMPRESSION);
Review comment:
Hi @adorn what if we keep the default behaviour (i.e. use default compression level) but allow users to change it?
See https://github.com/adorn/commons-imaging/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 346647)
Remaining Estimate: 0h
Time Spent: 10m
> PNG Writer Indexed Color with semi-transparent Pixels and Better Compression
> ----------------------------------------------------------------------------
>
> Key: IMAGING-243
> URL: https://issues.apache.org/jira/browse/IMAGING-243
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: PNG
> Affects Versions: 1.0-alpha1
> Reporter: Andreas
> Assignee: Bruno P. Kinoshita
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.0-alpha2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I updated the PNG-Writer for smaller png-Files:
> * PNG Writer Indexed Color with semi-transparent Pixels
> * Better Compression
>
> See Pull-Request: [https://github.com/apache/commons-imaging/pull/58]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)