You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/18 15:15:14 UTC

[GitHub] [camel] JiriOndrusek opened a new pull request #5102: CAMEL-16232 Fixing 2-way ssl via system properties

JiriOndrusek opened a new pull request #5102:
URL: https://github.com/apache/camel/pull/5102


   fixes https://issues.apache.org/jira/browse/CAMEL-16232
   
   There is a limitation with tests, which effects tested use case. There is already one test using systemProperties flag. Unfortunately this test creates sslContext, which is probably cached. If another test tries to use system properties to create different sslContext, old one is used. (in this case without keyManager)
   I see several approaches to solve this problem: 
   
   1. Put all tests with systemProperties into one file and change them to "cooperate" - then there is only one sslContext created
   2. Start tests in forked JVM - better solution, but I didn't find a declarative way to run only several tests in forked mode. I'm not sure that executingd all tests in the component via forked mode is preferred solution. If so, I can change the test to be in separated class and enable forked mode for all tests. WDYT?
   
   This PR contains solution one. I merged old test with new one.
   
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #5102: CAMEL-16232 Fixing 2-way ssl via system properties

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5102:
URL: https://github.com/apache/camel/pull/5102


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org