You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/07/21 19:02:57 UTC
Re: Review Request 36585: Exposed docker container IP via state.json
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36585/
-----------------------------------------------------------
(Updated July 21, 2015, 1:02 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen.
Changes
-------
Updated to expsoe just the IP.
Summary (updated)
-----------------
Exposed docker container IP via state.json
Bugs: MESOS-3061
https://issues.apache.org/jira/browse/MESOS-3061
Repository: mesos
Description (updated)
-------
This would allow Mesos-DNS to lookup container information such as its
IP address.
Diffs (updated)
-----
src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504
src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16
src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d
src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43
Diff: https://reviews.apache.org/r/36585/diff/
Testing
-------
sudo make check
Thanks,
Kapil Arya
Re: Review Request 36585: Exposed docker container IP via state.json
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36585/#review92452
-----------------------------------------------------------
src/docker/executor.cpp (line 163)
<https://reviews.apache.org/r/36585/#comment146623>
I like this a lot better, but I'm still thinking if this is what labels are intended for, and what is the implications of storing this in the labels.
- Timothy Chen
On July 21, 2015, 5:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36585/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen.
>
>
> Bugs: MESOS-3061
> https://issues.apache.org/jira/browse/MESOS-3061
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would allow Mesos-DNS to lookup container information such as its
> IP address.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504
> src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16
> src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d
> src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43
>
> Diff: https://reviews.apache.org/r/36585/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 36585: Exposed docker container IP via state.json
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36585/#review92471
-----------------------------------------------------------
Ship it!
src/tests/docker_containerizer_tests.cpp (line 729)
<https://reviews.apache.org/r/36585/#comment146670>
Need to flip expectation and actual.
- Benjamin Hindman
On July 21, 2015, 5:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36585/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen.
>
>
> Bugs: MESOS-3061
> https://issues.apache.org/jira/browse/MESOS-3061
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would allow Mesos-DNS to lookup container information such as its
> IP address.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504
> src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16
> src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d
> src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43
>
> Diff: https://reviews.apache.org/r/36585/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 36585: Exposed docker container IP via state.json
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36585/#review92456
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36574, 36575, 36580, 36585]
All tests passed.
- Mesos ReviewBot
On July 21, 2015, 5:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36585/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen.
>
>
> Bugs: MESOS-3061
> https://issues.apache.org/jira/browse/MESOS-3061
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would allow Mesos-DNS to lookup container information such as its
> IP address.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504
> src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16
> src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d
> src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43
>
> Diff: https://reviews.apache.org/r/36585/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Kapil Arya
>
>