[jira] [Comment Edited] (OAK-3973) There should be a way to get filtered suggestions based on some path

["Vikas Saurabh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135806#comment-15135806 ] 

Vikas Saurabh edited comment on OAK-3973 at 2/6/16 3:04 PM:
------------------------------------------------------------

Discussed with [~chetanm] and it {{jcr:path=}} might not be a good idea. So, we'd use descendantnode clause.

Opened a set of sub-tasks to break use-cases. Moving this issue to 1.6 while keeping the simplest sub-task (OAK-3994) for 1.4.

Attaching a wip [patch|^OAK-3973.wip.patch] which has a fix (still to be cleaned up) for OAK-3994 and tests cases (for suggestions only yet) for sub-tasks (ignoring the one we might want to fix just yet).

[~chetanm], [~teofili], can you please take a look (and possibly other cases that we should cover)


was (Author: catholicon):
Discussed with [~chetanm] and it {{jcr:path=}} might not be a good idea. So, we'd use descendantnode clause.

Opened a set of sub-tasks to break use-cases. Moving this issue to 1.6 while keeping the simplest sub-task (OAK-3994) for 1.4.

Attaching a wip [patch|^OAK-3973.wip.patch] which has a fix for OAK-3994 and tests cases (for suggestions only yet) for sub-tasks (ignoring the one we might want to fix just yet).

[~chetanm], [~teofili], can you please take a look (and possibly other cases that we should cover)

> There should be a way to get filtered suggestions based on some path
> --------------------------------------------------------------------
>
>                 Key: OAK-3973
>                 URL: https://issues.apache.org/jira/browse/OAK-3973
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>             Fix For: 1.6
>
>         Attachments: OAK-3973.wip.patch
>
>
> Currently, suggestions are indexed at index level - so, when querying for suggestions, the result incorporates all documents indexed by that document.
> So, this doesn't allow filtering suggestions for a subset of indexed document - at least we should be able to get filtered suggestion based on a root path.
> This seems very similar to a functionality provided by lucene vide LUCENE-5528 which was fixed in lucene 4.8. Since oak is still on 4.7, so, we can't exploit that feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)