You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Ron Gavlin (JIRA)" <ji...@apache.org> on 2008/11/13 13:18:05 UTC

[jira] Created: (SM-1686) smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only

smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only
-----------------------------------------------------------------------------------------------------------------------------------------

                 Key: SM-1686
                 URL: https://issues.apache.org/activemq/browse/SM-1686
             Project: ServiceMix
          Issue Type: Bug
          Components: servicemix-camel
    Affects Versions: servicemix-camel-2008.01
            Reporter: Ron Gavlin


See SM-1673 for test case that exposes the problem. It appears the problem might be between smx-camel and the camel HandleFaultProcessor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1686) smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only

Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey updated SM-1686:
--------------------------------

    Attachment: SM-1686-32branch.patch

Patch for the servicemix3.2 branch.

> smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1686
>                 URL: https://issues.apache.org/activemq/browse/SM-1686
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-camel
>    Affects Versions: servicemix-camel-2008.01
>            Reporter: Ron Gavlin
>         Attachments: SM-1686-32branch.patch, SM-1686.patch
>
>
> See SM-1673 for test case that exposes the problem. Specifically, notice the extract below from file  servicemix-camel/src/test/resources/org/apache/servicemix/camel/su9-src/camel-context.xml. The in-only message exchange fault is caught with exception org.apache.servicemix.jbi.FaultException while the robust-in-only message exchange fault is caught with exception org.apache.camel.CamelException. It would seem to make more sense for the same org.apache.servicemix.jbi.FaultException to be used in both cases.
> /Ron
>   <camelContext  xmlns="http://activemq.apache.org/camel/schema/spring">
>     <route errorHandlerRef="deadLetterErrorHandler">
>       <from uri="jbi:service:urn:test:fault-handled-true"/>
>       <onException>
>         <!-- Catch exception from in-only message exchange -->
>         <exception>org.apache.servicemix.jbi.FaultException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <onException>
>         <!-- Catch exception from robust-in-only message exchange -->
>         <exception>org.apache.camel.CamelException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <interceptor ref="handleFaultProcessor">
>         <to uri="jbi:service:urn:test:faulty-service"/>
>       </interceptor>
>     </route>
>   </camelContext>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SM-1686) smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gert Vanthienen resolved SM-1686.
---------------------------------

         Assignee: Jonathan Anstey
    Fix Version/s: servicemix-camel-2008.02
                   3.2.4
       Resolution: Fixed

Patches have been applied:
- http://svn.eu.apache.org/viewvc?view=rev&revision=721466 for 3.2 branch
- http://svn.eu.apache.org/viewvc?view=rev&revision=721488 for components' trunk

Many thanks to Jonathan Anstey for providing the patches!


> smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1686
>                 URL: https://issues.apache.org/activemq/browse/SM-1686
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-camel
>    Affects Versions: servicemix-camel-2008.01
>            Reporter: Ron Gavlin
>            Assignee: Jonathan Anstey
>             Fix For: servicemix-camel-2008.02, 3.2.4
>
>         Attachments: SM-1686-32branch.patch, SM-1686-trunk.patch, SM-1686.patch
>
>
> See SM-1673 for test case that exposes the problem. Specifically, notice the extract below from file  servicemix-camel/src/test/resources/org/apache/servicemix/camel/su9-src/camel-context.xml. The in-only message exchange fault is caught with exception org.apache.servicemix.jbi.FaultException while the robust-in-only message exchange fault is caught with exception org.apache.camel.CamelException. It would seem to make more sense for the same org.apache.servicemix.jbi.FaultException to be used in both cases.
> /Ron
>   <camelContext  xmlns="http://activemq.apache.org/camel/schema/spring">
>     <route errorHandlerRef="deadLetterErrorHandler">
>       <from uri="jbi:service:urn:test:fault-handled-true"/>
>       <onException>
>         <!-- Catch exception from in-only message exchange -->
>         <exception>org.apache.servicemix.jbi.FaultException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <onException>
>         <!-- Catch exception from robust-in-only message exchange -->
>         <exception>org.apache.camel.CamelException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <interceptor ref="handleFaultProcessor">
>         <to uri="jbi:service:urn:test:faulty-service"/>
>       </interceptor>
>     </route>
>   </camelContext>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1686) smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only

Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron Gavlin updated SM-1686:
---------------------------

    Description: 
See SM-1673 for test case that exposes the problem. Specifically, notice the extract below from file  servicemix-camel/src/test/resources/org/apache/servicemix/camel/su9-src/camel-context.xml. The in-only message exchange fault is caught with exception org.apache.servicemix.jbi.FaultException while the robust-in-only message exchange fault is caught with exception org.apache.camel.CamelException. It would seem to make more sense for the same org.apache.servicemix.jbi.FaultException to be used in both cases.

/Ron


  <camelContext  xmlns="http://activemq.apache.org/camel/schema/spring">
    <route errorHandlerRef="deadLetterErrorHandler">
      <from uri="jbi:service:urn:test:fault-handled-true"/>
      <onException>
        <!-- Catch exception from in-only message exchange -->
        <exception>org.apache.servicemix.jbi.FaultException</exception>
        <redeliveryPolicy maximumRedeliveries="0"/>
        <handled>
          <constant>true</constant>
        </handled>
        <to uri="jbi:service:urn:test:receiver-service"/>
      </onException>
      <onException>
        <!-- Catch exception from robust-in-only message exchange -->
        <exception>org.apache.camel.CamelException</exception>
        <redeliveryPolicy maximumRedeliveries="0"/>
        <handled>
          <constant>true</constant>
        </handled>
        <to uri="jbi:service:urn:test:receiver-service"/>
      </onException>
      <interceptor ref="handleFaultProcessor">
        <to uri="jbi:service:urn:test:faulty-service"/>
      </interceptor>
    </route>
  </camelContext>


  was:See SM-1673 for test case that exposes the problem. It appears the problem might be between smx-camel and the camel HandleFaultProcessor.


Provided more detail in problem description.

> smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1686
>                 URL: https://issues.apache.org/activemq/browse/SM-1686
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-camel
>    Affects Versions: servicemix-camel-2008.01
>            Reporter: Ron Gavlin
>
> See SM-1673 for test case that exposes the problem. Specifically, notice the extract below from file  servicemix-camel/src/test/resources/org/apache/servicemix/camel/su9-src/camel-context.xml. The in-only message exchange fault is caught with exception org.apache.servicemix.jbi.FaultException while the robust-in-only message exchange fault is caught with exception org.apache.camel.CamelException. It would seem to make more sense for the same org.apache.servicemix.jbi.FaultException to be used in both cases.
> /Ron
>   <camelContext  xmlns="http://activemq.apache.org/camel/schema/spring">
>     <route errorHandlerRef="deadLetterErrorHandler">
>       <from uri="jbi:service:urn:test:fault-handled-true"/>
>       <onException>
>         <!-- Catch exception from in-only message exchange -->
>         <exception>org.apache.servicemix.jbi.FaultException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <onException>
>         <!-- Catch exception from robust-in-only message exchange -->
>         <exception>org.apache.camel.CamelException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <interceptor ref="handleFaultProcessor">
>         <to uri="jbi:service:urn:test:faulty-service"/>
>       </interceptor>
>     </route>
>   </camelContext>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1686) smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only

Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey updated SM-1686:
--------------------------------

    Attachment: SM-1686.patch

Attached is a patch to fix the issue. There is also a required fix in Camel (see http://svn.apache.org/viewvc?view=rev&revision=721306). 

The patch should be applied to http://svn.apache.org/repos/asf/servicemix/components/engines/servicemix-camel/trunk/

> smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1686
>                 URL: https://issues.apache.org/activemq/browse/SM-1686
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-camel
>    Affects Versions: servicemix-camel-2008.01
>            Reporter: Ron Gavlin
>         Attachments: SM-1686.patch
>
>
> See SM-1673 for test case that exposes the problem. Specifically, notice the extract below from file  servicemix-camel/src/test/resources/org/apache/servicemix/camel/su9-src/camel-context.xml. The in-only message exchange fault is caught with exception org.apache.servicemix.jbi.FaultException while the robust-in-only message exchange fault is caught with exception org.apache.camel.CamelException. It would seem to make more sense for the same org.apache.servicemix.jbi.FaultException to be used in both cases.
> /Ron
>   <camelContext  xmlns="http://activemq.apache.org/camel/schema/spring">
>     <route errorHandlerRef="deadLetterErrorHandler">
>       <from uri="jbi:service:urn:test:fault-handled-true"/>
>       <onException>
>         <!-- Catch exception from in-only message exchange -->
>         <exception>org.apache.servicemix.jbi.FaultException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <onException>
>         <!-- Catch exception from robust-in-only message exchange -->
>         <exception>org.apache.camel.CamelException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <interceptor ref="handleFaultProcessor">
>         <to uri="jbi:service:urn:test:faulty-service"/>
>       </interceptor>
>     </route>
>   </camelContext>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SM-1686) smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only

Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/SM-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey updated SM-1686:
--------------------------------

    Attachment: SM-1686-trunk.patch

Patch for http://svn.apache.org/repos/asf/servicemix/components/engines/servicemix-camel/trunk/

Ignore the first patch for trunk. I didn't need to handle several different versions of ServiceMix in the same component. 

> smx-camel errorHandler w/handleFault="true" should consistently throw JBIFaultException and not CamelException when mep is robust-in-only
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SM-1686
>                 URL: https://issues.apache.org/activemq/browse/SM-1686
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-camel
>    Affects Versions: servicemix-camel-2008.01
>            Reporter: Ron Gavlin
>         Attachments: SM-1686-32branch.patch, SM-1686-trunk.patch, SM-1686.patch
>
>
> See SM-1673 for test case that exposes the problem. Specifically, notice the extract below from file  servicemix-camel/src/test/resources/org/apache/servicemix/camel/su9-src/camel-context.xml. The in-only message exchange fault is caught with exception org.apache.servicemix.jbi.FaultException while the robust-in-only message exchange fault is caught with exception org.apache.camel.CamelException. It would seem to make more sense for the same org.apache.servicemix.jbi.FaultException to be used in both cases.
> /Ron
>   <camelContext  xmlns="http://activemq.apache.org/camel/schema/spring">
>     <route errorHandlerRef="deadLetterErrorHandler">
>       <from uri="jbi:service:urn:test:fault-handled-true"/>
>       <onException>
>         <!-- Catch exception from in-only message exchange -->
>         <exception>org.apache.servicemix.jbi.FaultException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <onException>
>         <!-- Catch exception from robust-in-only message exchange -->
>         <exception>org.apache.camel.CamelException</exception>
>         <redeliveryPolicy maximumRedeliveries="0"/>
>         <handled>
>           <constant>true</constant>
>         </handled>
>         <to uri="jbi:service:urn:test:receiver-service"/>
>       </onException>
>       <interceptor ref="handleFaultProcessor">
>         <to uri="jbi:service:urn:test:faulty-service"/>
>       </interceptor>
>     </route>
>   </camelContext>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.