You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 09:35:22 UTC

[GitHub] [airflow] feluelle commented on pull request #12096: add xcom push for ECSOperator

feluelle commented on pull request #12096:
URL: https://github.com/apache/airflow/pull/12096#issuecomment-747976100


   > > Could you please add tests.
   > 
   > Sure, I'll need to understand how the operator is currently tested.
   
   You can find the tests here: https://github.com/apache/airflow/blob/master/tests/providers/amazon/aws/operators/test_ecs.py
   Just add one that tests that the executes returns the data you expect. You can use `unittest.mock` to mock the ecs (boto3) under the hood.
   
   > > There are many branches returning `None`. Wouldn't it be possible and more clearer if we combine them?
   > 
   > Yes, please let me know if you think it's ok now.
   
   Yes, looks good now :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org