You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/03/24 01:53:55 UTC

Re: Review Request 57762: Relocated environment duplication warnings.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/
-----------------------------------------------------------

(Updated March 24, 2017, 1:53 a.m.)


Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.


Summary (updated)
-----------------

Relocated environment duplication warnings.


Bugs: MESOS-7263
    https://issues.apache.org/jira/browse/MESOS-7263


Repository: mesos


Description
-------

see summary.


Diffs
-----

  src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 


Diff: https://reviews.apache.org/r/57762/diff/4/


Testing
-------

make check + functional testing..

Before applying the patch;

Running 
```
$ ./src/mesos-execute --name="test" --env='{"key1":"value1"}' --command='sleep 1000' --master=127.0.0.1:5050
```
will result in the following `stdout` sandbox file:
```
Received SUBSCRIBED event
Subscribed executor on lobomacpro2.fritz.box
Received LAUNCH event
Starting task test
/Users/till/Development/mesos-private/build/src/mesos-containerizer launch --help="false" --launch_info="{"command":{"environment":{"variables":[{"name":"key1","type":"VALUE","value":"value1"}]},"shell":true,"value":"sleep 1000"},"environment":{"variables":[{"name":"BIN_SH","type":"VALUE","value":"xpg4"},{"name":"DUALCASE","type":"VALUE","value":"1"},{"name":"DYLD_LIBRARY_PATH","type":"VALUE","value":"\/Users\/till\/Development\/mesos-private\/build\/src\/.libs"},{"name":"LIBPROCESS_PORT","type":"VALUE","value":"0"},{"name":"MESOS_AGENT_ENDPOINT","type":"VALUE","value":"192.168.178.20:5051"},{"name":"MESOS_CHECKPOINT","type":"VALUE","value":"0"},{"name":"MESOS_DIRECTORY","type":"VALUE","value":"\/tmp\/mesos\/slaves\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0\/frameworks\/c84f9ee5-8a6b-4f6c-9fc0-154bceb3c615-0000\/executors\/test\/runs\/025c1d1a-6886-4b42-9313-0b1a411d5e39"},{"name":"MESOS_EXECUTOR_ID","type":"VALUE","value":"test"},{"name":"MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD","type":"
 VALUE","value":"5secs"},{"name":"MESOS_FRAMEWORK_ID","type":"VALUE","value":"c84f9ee5-8a6b-4f6c-9fc0-154bceb3c615-0000"},{"name":"MESOS_HTTP_COMMAND_EXECUTOR","type":"VALUE","value":"0"},{"name":"MESOS_SANDBOX","type":"VALUE","value":"\/tmp\/mesos\/slaves\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0\/frameworks\/c84f9ee5-8a6b-4f6c-9fc0-154bceb3c615-0000\/executors\/test\/runs\/025c1d1a-6886-4b42-9313-0b1a411d5e39"},{"name":"MESOS_SLAVE_ID","type":"VALUE","value":"816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0"},{"name":"MESOS_SLAVE_PID","type":"VALUE","value":"slave(1)@192.168.178.20:5051"},{"name":"PATH","type":"VALUE","value":"\/usr\/local\/sbin:\/usr\/local\/bin:\/usr\/sbin:\/usr\/bin:\/sbin:\/bin"},{"name":"PWD","type":"VALUE","value":"\/private\/tmp\/mesos\/slaves\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0\/frameworks\/c84f9ee5-8a6b-4f6c-9fc0-154bceb3c615-0000\/executors\/test\/runs\/025c1d1a-6886-4b42-9313-0b1a411d5e39"},{"name":"SHLVL","type":"VALUE","value":"0"},{"name":"__CF_USER_TEXT_E
 NCODING","type":"VALUE","value":"0x1F5:0x0:0x0"},{"name":"key1","type":"VALUE","value":"value1"},{"name":"key1","type":"VALUE","value":"value1"}]}}"
Forked command at 2376
Overwriting environment variable 'key1', original: 'value1', new: 'value1'
```

After applying the patch;

The resulting `stdout` sandbox file is as clean as it should be:
```
Received SUBSCRIBED event
Subscribed executor on lobomacpro2.fritz.box
Received LAUNCH event
Starting task test
/Users/till/Development/mesos-private/build/src/mesos-containerizer launch --help="false" --launch_info="{"command":{"environment":{"variables":[{"name":"key1","type":"VALUE","value":"value1"}]},"shell":true,"value":"sleep 1000"},"environment":{"variables":[{"name":"PATH","type":"VALUE","value":"\/usr\/local\/sbin:\/usr\/local\/bin:\/usr\/sbin:\/usr\/bin:\/sbin:\/bin"},{"name":"PWD","type":"VALUE","value":"\/private\/tmp\/mesos\/slaves\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0\/frameworks\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-0000\/executors\/test\/runs\/46f219a3-2772-4d21-89b8-85f1c1ba362e"},{"name":"MESOS_SLAVE_PID","type":"VALUE","value":"slave(1)@192.168.178.20:5051"},{"name":"MESOS_FRAMEWORK_ID","type":"VALUE","value":"816619b6-f5ce-42d6-ad6b-2ef2001adc0a-0000"},{"name":"MESOS_EXECUTOR_ID","type":"VALUE","value":"test"},{"name":"MESOS_CHECKPOINT","type":"VALUE","value":"0"},{"name":"MESOS_SLAVE_ID","type":"VALUE","value":"816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0"},{"name":"MESOS_S
 ANDBOX","type":"VALUE","value":"\/tmp\/mesos\/slaves\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0\/frameworks\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-0000\/executors\/test\/runs\/46f219a3-2772-4d21-89b8-85f1c1ba362e"},{"name":"MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD","type":"VALUE","value":"5secs"},{"name":"SHLVL","type":"VALUE","value":"0"},{"name":"DUALCASE","type":"VALUE","value":"1"},{"name":"key1","type":"VALUE","value":"value1"},{"name":"MESOS_AGENT_ENDPOINT","type":"VALUE","value":"192.168.178.20:5051"},{"name":"DYLD_LIBRARY_PATH","type":"VALUE","value":"\/Users\/till\/Development\/mesos-private\/build\/src\/.libs"},{"name":"BIN_SH","type":"VALUE","value":"xpg4"},{"name":"MESOS_HTTP_COMMAND_EXECUTOR","type":"VALUE","value":"0"},{"name":"__CF_USER_TEXT_ENCODING","type":"VALUE","value":"0x1F5:0x0:0x0"},{"name":"MESOS_DIRECTORY","type":"VALUE","value":"\/tmp\/mesos\/slaves\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-S0\/frameworks\/816619b6-f5ce-42d6-ad6b-2ef2001adc0a-0000\/executors\/test\/ru
 ns\/46f219a3-2772-4d21-89b8-85f1c1ba362e"},{"name":"LIBPROCESS_PORT","type":"VALUE","value":"0"}]}}"
Forked command at 90766
```


Thanks,

Till Toenshoff

Re: Review Request 57762: Fixed environment duplication in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/#review169957
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On March 24, 2017, 2:24 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57762/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 2:24 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7263
>     https://issues.apache.org/jira/browse/MESOS-7263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 
> 
> 
> Diff: https://reviews.apache.org/r/57762/diff/7/
> 
> 
> Testing
> -------
> 
> make check + functional testing..
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 57762: Fixed environment duplication in command executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On March 24, 2017, 2:29 a.m., Adam B wrote:
> > src/launcher/executor.cpp
> > Lines 494 (patched)
> > <https://reviews.apache.org/r/57762/diff/7/?file=1673749#file1673749line494>
> >
> >     "Overwriting environment variable 'foo' with value from task environment."

This is not necessarily true. Duplicates might be in task environment as well.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/#review169955
-----------------------------------------------------------


On March 24, 2017, 2:24 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57762/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 2:24 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7263
>     https://issues.apache.org/jira/browse/MESOS-7263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 
> 
> 
> Diff: https://reviews.apache.org/r/57762/diff/7/
> 
> 
> Testing
> -------
> 
> make check + functional testing..
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 57762: Fixed environment duplication in command executor.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/#review169955
-----------------------------------------------------------


Fix it, then Ship it!




I've got some nits, but nothing major.


src/launcher/executor.cpp
Line 473 (original), 483 (patched)
<https://reviews.apache.org/r/57762/#comment242674>

    Technically the default, so you don't have to set it.



src/launcher/executor.cpp
Lines 491 (patched)
<https://reviews.apache.org/r/57762/#comment242675>

    Not my favorite wrapping, but I'd allow it. I'd probably prefer:
    ```
          foreach (const Environment::Variable& variable,
                   taskEnvironment->variables()) {
    ```



src/launcher/executor.cpp
Lines 494 (patched)
<https://reviews.apache.org/r/57762/#comment242677>

    "Overwriting environment variable 'foo' with value from task environment."



src/launcher/executor.cpp
Lines 497 (patched)
<https://reviews.apache.org/r/57762/#comment242676>

    No need to overwrite if the value is the same. Not a big deal if you do though.



src/launcher/executor.cpp
Lines 507 (patched)
<https://reviews.apache.org/r/57762/#comment242678>

    "Overwriting environment variable 'foo' with value from command environment."


- Adam B


On March 23, 2017, 7:24 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57762/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 7:24 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7263
>     https://issues.apache.org/jira/browse/MESOS-7263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 
> 
> 
> Diff: https://reviews.apache.org/r/57762/diff/7/
> 
> 
> Testing
> -------
> 
> make check + functional testing..
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 57762: Fixed environment duplication in command executor.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/#review169985
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57762]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 24, 2017, 2:24 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57762/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 2:24 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-7263
>     https://issues.apache.org/jira/browse/MESOS-7263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 
> 
> 
> Diff: https://reviews.apache.org/r/57762/diff/7/
> 
> 
> Testing
> -------
> 
> make check + functional testing..
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 57762: Fixed environment duplication in command executor.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/
-----------------------------------------------------------

(Updated March 24, 2017, 2:24 a.m.)


Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.


Summary (updated)
-----------------

Fixed environment duplication in command executor.


Bugs: MESOS-7263
    https://issues.apache.org/jira/browse/MESOS-7263


Repository: mesos


Description
-------

see summary.


Diffs
-----

  src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 


Diff: https://reviews.apache.org/r/57762/diff/7/


Testing
-------

make check + functional testing..


Thanks,

Till Toenshoff

Re: Review Request 57762: Fixed environment duplication in default executor.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/
-----------------------------------------------------------

(Updated March 24, 2017, 2:19 a.m.)


Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.


Changes
-------

jeez - I am too tired I guess....


Bugs: MESOS-7263
    https://issues.apache.org/jira/browse/MESOS-7263


Repository: mesos


Description
-------

see summary.


Diffs (updated)
-----

  src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 


Diff: https://reviews.apache.org/r/57762/diff/7/

Changes: https://reviews.apache.org/r/57762/diff/6-7/


Testing
-------

make check + functional testing..


Thanks,

Till Toenshoff

Re: Review Request 57762: Fixed environment duplication in default executor.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57762/
-----------------------------------------------------------

(Updated March 24, 2017, 2:10 a.m.)


Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and Joseph Wu.


Bugs: MESOS-7263
    https://issues.apache.org/jira/browse/MESOS-7263


Repository: mesos


Description
-------

see summary.


Diffs (updated)
-----

  src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f 


Diff: https://reviews.apache.org/r/57762/diff/6/

Changes: https://reviews.apache.org/r/57762/diff/5-6/


Testing
-------

make check + functional testing..


Thanks,

Till Toenshoff