[kudu-CR] Make NO FATALS work standalone

["Mike Percy (Code Review)" <ge...@cloudera.org>]

Mike Percy has posted comments on this change.

Change subject: Make NO_FATALS work standalone
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6730/1/src/kudu/util/test_macros.h
File src/kudu/util/test_macros.h:

Line 23: // ASSERT_NO_FATAL_FAILURE is just too long to type.
> would it be clearer to leave this as is, and add a new #define like 'NO_PEN
Adar: I didn't investigate the lambda issue but I thought of a somewhat better workaround than this so I'm about to post it to this patch.

Todd: Sounds reasonable, I took this patch in the direction you suggested instead. Will post it here.


-- 
To view, visit http://gerrit.cloudera.org:8080/6730
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia004214d21a09ca0523ea11d88d2cd4ff783a1ca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes