You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/05 07:48:20 UTC

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1654: HBASE-24311 Add more details in MultiVersionConcurrencyControl STUCK …

anoopsjohn commented on a change in pull request #1654:
URL: https://github.com/apache/hbase/pull/1654#discussion_r419922765



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java
##########
@@ -225,11 +233,12 @@ void waitForRead(WriteEntry e) {
     synchronized (readWaiters) {
       while (readPoint.get() < e.getWriteNumber()) {
         if (count % 100 == 0 && count > 0) {
-          LOG.warn("STUCK: " + this);
+          long totalWaitTillNow = READPOINT_ADVANCE_WAIT_TIME * count;
+          LOG.warn("STUCK for : " + totalWaitTillNow + " millis. " + this);

Review comment:
       Ideally WARN level will be enabled always. That is why I thought its ok to keep this existing way. I pushed master branch already this way. If u strongly feel we need to change,  I can change. Might have to put addendum on Master. wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org