You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Adriano Crestani <ad...@apache.org> on 2011/04/25 02:07:05 UTC
Re: Small issue in queryparser // QueryNodeImpl.java
Hi Karsten,
I received an email when you commented on LUCENE-2867, but I couldn't find
the comment on the JIRA itself.
Anyway, thanks for reporting this bug, I create a JIRA for that
(LUCENE-2045) and already started working on it.
Best Regards,
Adriano Crestani
On Sun, Apr 24, 2011 at 5:49 PM, Karsten Fissmer <ka...@gmx.de>wrote:
> Hi Adriano Crestani,
>
> I made a comment in
> https://issues.apache.org/jira/browse/LUCENE-2867 :
>
> Since your changes in Rev. 1063065 "applying patches from LUCENE-2855 and
> LUCENE-2867 to trunk" there is a problem with method "containsTag" in class
>
> lucene/contrib/queryparser/src/java/org/apache/lucene/queryParser/core/nodes/QueryNodeImpl.java
>
> old source-code:
>
> public boolean containsTag(CharSequence tagName) {
> return this.tags.containsKey(tagName.toString().toLowerCase());
> }
>
> public Object getTag(CharSequence tagName) {
> return this.tags.get(tagName.toString().toLowerCase());
> }
>
> current source-code:
>
> /** verify if a node contains a tag */
> public boolean containsTag(String tagName) {
> return this.tags.containsKey(tagName);
> }
>
> public Object getTag(String tagName) {
> return this.tags.get(tagName.toString().toLowerCase());
> }
>
> so there is a missing ".toLowerCase()".
>
>
>
> Best regards
>
> Karsten
> http://www.xing.com/profile/Karsten_Fissmer
>
>
> P.S. currently I am working on new QueryBuilder classes to generate
> SpanQueries from QueryNodes. Is this work already down by someone else?
>
Re: Small issue in queryparser // QueryNodeImpl.java
Posted by Adriano Crestani <ad...@apache.org>.
I mean, LUCENE-3045
On Sun, Apr 24, 2011 at 8:07 PM, Adriano Crestani <
adrianocrestani@apache.org> wrote:
> Hi Karsten,
>
> I received an email when you commented on LUCENE-2867, but I couldn't find
> the comment on the JIRA itself.
>
> Anyway, thanks for reporting this bug, I create a JIRA for that
> (LUCENE-2045) and already started working on it.
>
> Best Regards,
> Adriano Crestani
>
> On Sun, Apr 24, 2011 at 5:49 PM, Karsten Fissmer <ka...@gmx.de>wrote:
>
>> Hi Adriano Crestani,
>>
>> I made a comment in
>> https://issues.apache.org/jira/browse/LUCENE-2867 :
>>
>> Since your changes in Rev. 1063065 "applying patches from LUCENE-2855 and
>> LUCENE-2867 to trunk" there is a problem with method "containsTag" in class
>>
>> lucene/contrib/queryparser/src/java/org/apache/lucene/queryParser/core/nodes/QueryNodeImpl.java
>>
>> old source-code:
>>
>> public boolean containsTag(CharSequence tagName) {
>> return this.tags.containsKey(tagName.toString().toLowerCase());
>> }
>>
>> public Object getTag(CharSequence tagName) {
>> return this.tags.get(tagName.toString().toLowerCase());
>> }
>>
>> current source-code:
>>
>> /** verify if a node contains a tag */
>> public boolean containsTag(String tagName) {
>> return this.tags.containsKey(tagName);
>> }
>>
>> public Object getTag(String tagName) {
>> return this.tags.get(tagName.toString().toLowerCase());
>> }
>>
>> so there is a missing ".toLowerCase()".
>>
>>
>>
>> Best regards
>>
>> Karsten
>> http://www.xing.com/profile/Karsten_Fissmer
>>
>>
>> P.S. currently I am working on new QueryBuilder classes to generate
>> SpanQueries from QueryNodes. Is this work already down by someone else?
>>
>
>