You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2024/07/03 09:29:52 UTC
[PR] [fix](spill) Adjust the logic for triggering spilling [doris]
mrhhsg opened a new pull request, #37221:
URL: https://github.com/apache/doris/pull/37221
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205722154
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205736631
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205724456
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg merged PR #37221:
URL: https://github.com/apache/doris/pull/37221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205574624
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205722358
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205563166
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205778272
<details>
<summary>TPC-DS: <b>Total hot run time: 169770 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4b7fa8715dfe688773d8129c9c2d141e0481b198, data reload: false
query1 918 374 366 366
query2 6477 2318 2351 2318
query3 6645 222 211 211
query4 19598 17472 17411 17411
query5 4185 486 489 486
query6 265 178 172 172
query7 4615 303 297 297
query8 331 302 284 284
query9 8648 2375 2382 2375
query10 611 287 276 276
query11 10454 10082 10006 10006
query12 132 85 84 84
query13 1683 358 366 358
query14 9420 6684 7602 6684
query15 245 187 185 185
query16 7799 264 271 264
query17 1895 551 530 530
query18 1949 275 270 270
query19 194 146 170 146
query20 88 89 82 82
query21 203 130 131 130
query22 4437 4000 4064 4000
query23 33684 33025 32957 32957
query24 12071 2943 2782 2782
query25 674 353 363 353
query26 1827 155 152 152
query27 3051 312 314 312
query28 7742 2067 2055 2055
query29 1143 612 602 602
query30 294 152 170 152
query31 960 727 735 727
query32 92 55 55 55
query33 774 302 315 302
query34 934 468 469 468
query35 760 678 611 611
query36 1067 946 959 946
query37 292 71 74 71
query38 2897 2767 2808 2767
query39 830 783 771 771
query40 282 125 124 124
query41 54 46 53 46
query42 112 96 99 96
query43 607 551 544 544
query44 1253 736 744 736
query45 190 165 158 158
query46 1070 693 723 693
query47 1897 1794 1814 1794
query48 382 309 307 307
query49 1194 412 403 403
query50 767 386 391 386
query51 6893 6741 6738 6738
query52 107 92 129 92
query53 361 288 281 281
query54 905 450 443 443
query55 74 72 71 71
query56 275 266 269 266
query57 1160 1046 1034 1034
query58 251 234 243 234
query59 3339 3251 3235 3235
query60 303 268 277 268
query61 95 90 91 90
query62 647 440 442 440
query63 329 286 293 286
query64 9849 2247 1729 1729
query65 3126 3086 3072 3072
query66 1386 327 337 327
query67 15691 14868 14809 14809
query68 4604 545 572 545
query69 521 386 317 317
query70 1056 1043 1021 1021
query71 400 274 278 274
query72 7047 5664 2756 2756
query73 739 322 318 318
query74 5987 5571 5539 5539
query75 3471 2669 2666 2666
query76 2733 941 888 888
query77 486 295 296 295
query78 10331 9917 9773 9773
query79 2479 520 504 504
query80 1928 464 470 464
query81 578 219 216 216
query82 1338 110 103 103
query83 284 171 164 164
query84 246 91 83 83
query85 1569 276 264 264
query86 487 330 306 306
query87 3275 3069 3090 3069
query88 3949 2464 2436 2436
query89 461 376 373 373
query90 1836 181 181 181
query91 126 99 98 98
query92 67 50 48 48
query93 2335 528 520 520
query94 1232 187 195 187
query95 412 325 328 325
query96 601 342 266 266
query97 3188 3024 3058 3024
query98 223 213 189 189
query99 1305 852 838 838
Total cold run time: 277777 ms
Total hot run time: 169770 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205789435
<details>
<summary>ClickBench: <b>Total hot run time: 30.57 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4b7fa8715dfe688773d8129c9c2d141e0481b198, data reload: false
query1 0.04 0.04 0.02
query2 0.08 0.04 0.04
query3 0.22 0.05 0.05
query4 1.67 0.08 0.07
query5 0.50 0.52 0.49
query6 1.12 0.72 0.73
query7 0.02 0.01 0.01
query8 0.05 0.04 0.05
query9 0.53 0.49 0.49
query10 0.54 0.54 0.54
query11 0.15 0.11 0.11
query12 0.14 0.12 0.13
query13 0.59 0.59 0.59
query14 0.76 0.78 0.79
query15 0.84 0.80 0.81
query16 0.37 0.35 0.35
query17 0.93 1.02 1.06
query18 0.23 0.22 0.25
query19 1.76 1.75 1.65
query20 0.01 0.00 0.01
query21 15.44 0.77 0.66
query22 4.54 6.72 2.09
query23 18.31 1.42 1.24
query24 2.11 0.22 0.25
query25 0.16 0.09 0.08
query26 0.27 0.18 0.17
query27 0.08 0.08 0.08
query28 13.21 1.02 0.99
query29 12.64 3.27 3.21
query30 0.25 0.05 0.06
query31 2.89 0.38 0.39
query32 3.27 0.47 0.48
query33 2.84 2.88 2.94
query34 17.02 4.41 4.40
query35 4.48 4.48 4.48
query36 0.66 0.46 0.47
query37 0.18 0.15 0.16
query38 0.16 0.15 0.15
query39 0.05 0.03 0.05
query40 0.18 0.14 0.14
query41 0.09 0.04 0.04
query42 0.05 0.05 0.05
query43 0.04 0.04 0.05
Total cold run time: 109.47 s
Total hot run time: 30.57 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) Adjust the logic for triggering spilling [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37221:
URL: https://github.com/apache/doris/pull/37221#issuecomment-2205758094
<details>
<summary>TPC-H: <b>Total hot run time: 41184 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4b7fa8715dfe688773d8129c9c2d141e0481b198, data reload: false
------ Round 1 ----------------------------------
q1 17901 4712 4528 4528
q2 2489 205 197 197
q3 11607 1236 1154 1154
q4 10752 829 768 768
q5 7777 2833 2790 2790
q6 244 141 142 141
q7 1037 640 647 640
q8 9274 2271 2252 2252
q9 9010 6670 6631 6631
q10 9003 3813 3807 3807
q11 451 250 249 249
q12 441 250 235 235
q13 18703 2949 3025 2949
q14 278 240 242 240
q15 542 496 495 495
q16 533 382 393 382
q17 1009 717 632 632
q18 8066 7493 7483 7483
q19 7886 1661 1601 1601
q20 688 338 335 335
q21 5080 3323 4228 3323
q22 415 352 359 352
Total cold run time: 123186 ms
Total hot run time: 41184 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4563 4385 4441 4385
q2 396 259 261 259
q3 3048 2825 2784 2784
q4 1960 1611 1645 1611
q5 5369 5255 5352 5255
q6 241 133 133 133
q7 2179 1735 1734 1734
q8 3365 3522 3533 3522
q9 8400 8466 8431 8431
q10 3970 3710 3781 3710
q11 617 494 483 483
q12 820 626 616 616
q13 16280 3016 3003 3003
q14 297 272 261 261
q15 540 495 487 487
q16 485 413 416 413
q17 1894 1521 1544 1521
q18 7729 7557 7319 7319
q19 2157 1642 1742 1642
q20 2054 1811 1770 1770
q21 5117 4875 4927 4875
q22 643 541 579 541
Total cold run time: 72124 ms
Total hot run time: 54755 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org