[GitHub] [flink] twalthr commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

["twalthr (via GitHub)" <gi...@apache.org>]

twalthr commented on code in PR #21934:
URL: https://github.com/apache/flink/pull/21934#discussion_r1145933319


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdSize.scala:
##########
@@ -126,7 +126,7 @@ class FlinkRelMdSize private extends MetadataHandler[BuiltInMetadata.Size] {
     // get each column's RexNode (RexLiteral, RexInputRef or null)
     val projectNodes = (0 until fieldCount).map {
       i =>
-        val initNode: RexNode = rel.getCluster.getRexBuilder.constantNull()
+        val initNode: RexNode = rel.getCluster.getRexBuilder.makeNullLiteral(rel.getRowType)

Review Comment:
   Is this correct? Shouldn't it be `rel.getRowType.getField(i)`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org