You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/31 02:55:44 UTC

[GitHub] [hudi] hk-lrzy commented on a change in pull request #3006: [HUDI-1943] Lose properties when hoodieWriteConfig initializtion

hk-lrzy commented on a change in pull request #3006:
URL: https://github.com/apache/hudi/pull/3006#discussion_r642180903



##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -242,7 +242,9 @@ public static TypedProperties flinkConf2TypedProperties(Configuration conf) {
         properties.put(option.key(), option.defaultValue());
       }
     }
-    return new TypedProperties(properties);
+    TypedProperties typeProps = new TypedProperties();
+    typeProps.putAll(typeProps);

Review comment:
       Yeah，you are right， it should be `typeProps.putAll(properties)`.
   About question:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org