You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2016/01/25 00:21:47 UTC
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/626
Add Documentation page and outside links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton add-documentation-link
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/626.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #626
----
commit bcef6a750fa0971b10a7a26370fa8e5c7fee5a42
Author: michellephung <mi...@gmail.com>
Date: 2016-01-24T23:04:10Z
Add Documentation page and outside links
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#discussion_r50829583
--- Diff: app/addons/fauxton/navigation/tests/storeSpec.js ---
@@ -73,7 +73,9 @@ define([
link: link
});
- assert.equal(navBarStore.getBottomNavLinks()[1].id, link.id);
+ console.log(navBarStore.getBottomNavLinks());
--- End diff --
:japanese_ogre:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#issuecomment-177688954
things were done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#discussion_r50830065
--- Diff: app/addons/documentation/components.react.jsx ---
@@ -0,0 +1,66 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'react',
+ 'addons/documentation/stores'
+], function (app, FauxtonAPI, React, Stores) {
+
+ var documentationStore = Stores.documentationStore;
+
+ var DocumentationController = React.createClass({
+ getStoreState: function () {
+ return {
+ links: documentationStore.getLinks()
+ };
+ },
+
+ getInitialState: function () {
+ return this.getStoreState();
+ },
+
+ createLinkLine: function () {
+ return this.state.links.map(function (linkObject) {
+ return (
+ <tr key={linkObject.title}>
+ <td className="icons-container">
+ <div className={"icon " + linkObject.iconClassName}> </div>
+ </td>
+ <td>
+ <a href={linkObject.link} target="_blank" data-bypass="true">{linkObject.title}</a>
+ </td>
+ </tr>
+ );
+ });
+ },
+
+ render: function () {
+ console.log(this.state.links);
+ return (
+ <div id="documentation-page" className="scrollable">
+ <div className="links">
+ <table>
+ {this.createLinkLine()}
--- End diff --
can you add a tbody element? react 14 needs this (see https://github.com/apache/couchdb-fauxton/pull/617)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#discussion_r50830158
--- Diff: app/addons/documentation/components.react.jsx ---
@@ -0,0 +1,66 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'react',
+ 'addons/documentation/stores'
+], function (app, FauxtonAPI, React, Stores) {
+
+ var documentationStore = Stores.documentationStore;
+
+ var DocumentationController = React.createClass({
+ getStoreState: function () {
+ return {
+ links: documentationStore.getLinks()
+ };
+ },
+
+ getInitialState: function () {
+ return this.getStoreState();
+ },
+
+ createLinkLine: function () {
--- End diff --
createLinkLines
or maybe createLinkRows
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#issuecomment-177760147
+1- cool!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#issuecomment-174997756
looks great!
can you add a basic smoke test, e.g. a selenium test which checks that the links are listed and the module is loaded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Add Documentation page and outside l...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/626#discussion_r50830079
--- Diff: app/addons/documentation/components.react.jsx ---
@@ -0,0 +1,66 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+define([
+ 'app',
+ 'api',
+ 'react',
+ 'addons/documentation/stores'
+], function (app, FauxtonAPI, React, Stores) {
+
+ var documentationStore = Stores.documentationStore;
+
+ var DocumentationController = React.createClass({
+ getStoreState: function () {
+ return {
+ links: documentationStore.getLinks()
+ };
+ },
+
+ getInitialState: function () {
+ return this.getStoreState();
+ },
+
+ createLinkLine: function () {
+ return this.state.links.map(function (linkObject) {
+ return (
+ <tr key={linkObject.title}>
+ <td className="icons-container">
+ <div className={"icon " + linkObject.iconClassName}> </div>
+ </td>
+ <td>
+ <a href={linkObject.link} target="_blank" data-bypass="true">{linkObject.title}</a>
+ </td>
+ </tr>
+ );
+ });
+ },
+
+ render: function () {
+ console.log(this.state.links);
--- End diff --
:japanese_ogre:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---