You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Michael Gentry (JIRA)" <ji...@apache.org> on 2011/01/04 15:25:45 UTC
[jira] Created: (TAP5-1401) 5.2.4 Form's getDefaultTracker()
incompatible with 5.1.0.5
5.2.4 Form's getDefaultTracker() incompatible with 5.1.0.5
----------------------------------------------------------
Key: TAP5-1401
URL: https://issues.apache.org/jira/browse/TAP5-1401
Project: Tapestry 5
Issue Type: Bug
Components: documentation, tapestry-core
Affects Versions: 5.2.4
Reporter: Michael Gentry
Priority: Minor
In Tapestry 5.1.0.5, you can have code such as:
@Component
private Form inputs;
...
if (inputs.getDefaultTracker().getHasErrors())
...
This fails in 5.2.4 because getDefaultTracker() returns null if there are no errors. This appears to be related to this closed bug:
https://issues.apache.org/jira/browse/TAP5-979
Perhaps getDefaultTracker() should check for a null and return an empty one to be backwards compatible with 5.1.0.5? Alternatively, document it as a known incompatibility in the release notes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1401) 5.2.4 Form's getDefaultTracker()
incompatible with 5.1.0.5
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977371#action_12977371 ]
Howard M. Lewis Ship commented on TAP5-1401:
--------------------------------------------
Darn this grey area.
Form implements FormValidationControl; if you want to know if a Form has any errors, just invoke getHasErrors() directly on the Form. You should not need to invoke getDefaultTracker().
> 5.2.4 Form's getDefaultTracker() incompatible with 5.1.0.5
> ----------------------------------------------------------
>
> Key: TAP5-1401
> URL: https://issues.apache.org/jira/browse/TAP5-1401
> Project: Tapestry 5
> Issue Type: Bug
> Components: documentation, tapestry-core
> Affects Versions: 5.2.4
> Reporter: Michael Gentry
> Priority: Minor
>
> In Tapestry 5.1.0.5, you can have code such as:
> @Component
> private Form inputs;
> ...
> if (inputs.getDefaultTracker().getHasErrors())
> ...
> This fails in 5.2.4 because getDefaultTracker() returns null if there are no errors. This appears to be related to this closed bug:
> https://issues.apache.org/jira/browse/TAP5-979
> Perhaps getDefaultTracker() should check for a null and return an empty one to be backwards compatible with 5.1.0.5? Alternatively, document it as a known incompatibility in the release notes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (TAP5-1401) 5.2.4 Form's getDefaultTracker()
incompatible with 5.1.0.5
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1401.
--------------------------------------
Resolution: Invalid
Assignee: Howard M. Lewis Ship
Its unfortunate that sometimes components must implement public methods that are not intended to be invoked except under certain situations (perhaps we need to make that a @Property, or create a new annotation to identify "hands off" methods). In any case, see the workaround in the comments.
> 5.2.4 Form's getDefaultTracker() incompatible with 5.1.0.5
> ----------------------------------------------------------
>
> Key: TAP5-1401
> URL: https://issues.apache.org/jira/browse/TAP5-1401
> Project: Tapestry 5
> Issue Type: Bug
> Components: documentation, tapestry-core
> Affects Versions: 5.2.4
> Reporter: Michael Gentry
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> In Tapestry 5.1.0.5, you can have code such as:
> @Component
> private Form inputs;
> ...
> if (inputs.getDefaultTracker().getHasErrors())
> ...
> This fails in 5.2.4 because getDefaultTracker() returns null if there are no errors. This appears to be related to this closed bug:
> https://issues.apache.org/jira/browse/TAP5-979
> Perhaps getDefaultTracker() should check for a null and return an empty one to be backwards compatible with 5.1.0.5? Alternatively, document it as a known incompatibility in the release notes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TAP5-1401) 5.2.4 Form's getDefaultTracker()
incompatible with 5.1.0.5
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977371#action_12977371 ]
Howard M. Lewis Ship commented on TAP5-1401:
--------------------------------------------
Darn this grey area.
Form implements FormValidationControl; if you want to know if a Form has any errors, just invoke getHasErrors() directly on the Form. You should not need to invoke getDefaultTracker().
> 5.2.4 Form's getDefaultTracker() incompatible with 5.1.0.5
> ----------------------------------------------------------
>
> Key: TAP5-1401
> URL: https://issues.apache.org/jira/browse/TAP5-1401
> Project: Tapestry 5
> Issue Type: Bug
> Components: documentation, tapestry-core
> Affects Versions: 5.2.4
> Reporter: Michael Gentry
> Priority: Minor
>
> In Tapestry 5.1.0.5, you can have code such as:
> @Component
> private Form inputs;
> ...
> if (inputs.getDefaultTracker().getHasErrors())
> ...
> This fails in 5.2.4 because getDefaultTracker() returns null if there are no errors. This appears to be related to this closed bug:
> https://issues.apache.org/jira/browse/TAP5-979
> Perhaps getDefaultTracker() should check for a null and return an empty one to be backwards compatible with 5.1.0.5? Alternatively, document it as a known incompatibility in the release notes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (TAP5-1401) 5.2.4 Form's getDefaultTracker()
incompatible with 5.1.0.5
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1401.
--------------------------------------
Resolution: Invalid
Assignee: Howard M. Lewis Ship
Its unfortunate that sometimes components must implement public methods that are not intended to be invoked except under certain situations (perhaps we need to make that a @Property, or create a new annotation to identify "hands off" methods). In any case, see the workaround in the comments.
> 5.2.4 Form's getDefaultTracker() incompatible with 5.1.0.5
> ----------------------------------------------------------
>
> Key: TAP5-1401
> URL: https://issues.apache.org/jira/browse/TAP5-1401
> Project: Tapestry 5
> Issue Type: Bug
> Components: documentation, tapestry-core
> Affects Versions: 5.2.4
> Reporter: Michael Gentry
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> In Tapestry 5.1.0.5, you can have code such as:
> @Component
> private Form inputs;
> ...
> if (inputs.getDefaultTracker().getHasErrors())
> ...
> This fails in 5.2.4 because getDefaultTracker() returns null if there are no errors. This appears to be related to this closed bug:
> https://issues.apache.org/jira/browse/TAP5-979
> Perhaps getDefaultTracker() should check for a null and return an empty one to be backwards compatible with 5.1.0.5? Alternatively, document it as a known incompatibility in the release notes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira