You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Cliff Woolley <cl...@yahoo.com> on 2001/08/24 01:58:33 UTC
Re: cvs commit: httpd-2.0/server core.c
On 23 Aug 2001 trawick@apache.org wrote:
> trawick 01/08/23 16:49:41
>
> Modified: server core.c
> Log:
> fix fubar with recent commit to ap_core_translate()
>
> }
> - r->canonical_filename == r->filename;
> + r->canonical_filename = r->filename;
> }
> else {
> /*
> @@ -2933,7 +2933,7 @@
> != APR_SUCCESS) {
> return HTTP_FORBIDDEN;
> }
> - r->canonical_filename == r->filename;
> + r->canonical_filename = r->filename;
> }
>
Crap, and I saw those (briefly), too... I thought they looked strange for
some reason but didn't focus on it long enough to see the obvious. I
wonder why the hell didn't this cause a gcc warning?
--Cliff
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: cvs commit: httpd-2.0/server core.c
Posted by Cliff Woolley <cl...@yahoo.com>.
On 23 Aug 2001, Jeff Trawick wrote:
> > core.c: In function `ap_core_translate':
> > core.c:2921: warning: statement with no effect
> > core.c:2936: warning: statement with no effect
> > mod_include.c: In function `split_and_pass_pretag_buckets':
> > mod_include.c:122: warning: control reaches end of non-void function
> > mod_cgid.c: In function `split_and_pass_pretag_buckets':
> > mod_cgid.c:193: warning: control reaches end of non-void function
>
> gcc does if prodded properly
Damn, yep, they were in there--buried under half a million warnings from
mod_ssl. I turned off mod_ssl to clear the air, and sure enough there
they were right in front of my face.
Anyhow, good catch.
--Cliff
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: cvs commit: httpd-2.0/server core.c
Posted by Jeff Trawick <tr...@attglobal.net>.
Cliff Woolley <cl...@yahoo.com> writes:
> Crap, and I saw those (briefly), too... I thought they looked strange for
> some reason but didn't focus on it long enough to see the obvious. I
> wonder why the hell didn't this cause a gcc warning?
>From a regression test report:
/home/regress/regress/prevlogs/make.stderr and /home/regress/regress/logs/make.stderr are different!
------------------/home/regress/regress/logs/make.stderr.diff---------------
1,4c1,7
< make[3]: *** No rule to make target `os-inline.lo', needed by `libos.la'. Stop.
< make[2]: *** [all-recursive] Error 1
< make[1]: *** [all-recursive] Error 1
< make: *** [all-recursive] Error 1
---
> core.c: In function `ap_core_translate':
> core.c:2921: warning: statement with no effect
> core.c:2936: warning: statement with no effect
> mod_include.c: In function `split_and_pass_pretag_buckets':
> mod_include.c:122: warning: control reaches end of non-void function
> mod_cgid.c: In function `split_and_pass_pretag_buckets':
> mod_cgid.c:193: warning: control reaches end of non-void function
gcc does if prodded properly
Here was the invocation for that file:
/bin/sh /home/regress/regress/httpd-2.0/srclib/apr/libtool --silent --mode=compile gcc -g -O2 -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -DNO_DBM_REWRITEMAP -DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -DAP_DEBUG -I/usr/include/db1 -DAP_HAVE_DESIGNATED_INITIALIZER -I. -I/home/regress/regress/httpd-2.0/os/unix -I/home/regress/regress/httpd-2.0/server/mpm/threaded -I/home/regress/regress/httpd-2.0/modules/http -I/home/regress/regress/httpd-2.0/include -I/home/regress/regress/httpd-2.0/srclib/apr/include -I/home/regress/regress/httpd-2.0/srclib/apr-util/include -I/home/regress/regress/httpd-2.0/modules/dav/main -c core.c && touch core.lo
I'm gonna "fix" the mod_include and mod_cgi[d] warnings too. Paul and
Ryan can work out where the code goes eventually. For now, it seems
not just noisy but broken.
--
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...