You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/19 17:34:55 UTC
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request
#4832: [TE] fix mismatch in dataset names in data availability listener
akshayrai commented on a change in pull request #4832: [TE] fix mismatch in dataset names in data availability listener
URL: https://github.com/apache/incubator-pinot/pull/4832#discussion_r348061617
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityEventListener.java
##########
@@ -74,14 +74,18 @@ void processOneBatch() throws InterruptedException {
List<DataAvailabilityEvent> events = consumer.poll(pollTimeInMilli);
ThirdeyeMetricsUtil.triggerEventCounter.inc(events.size());
for (DataAvailabilityEvent event : events) {
- if (checkAllFiltersPassed(event)) {
- LOG.info("Processing event: " + event.getDatasetName() + " with watermark " + event.getHighWatermark());
- String dataset = event.getDatasetName();
- datasetTriggerInfoRepo.setLastUpdateTimestamp(dataset, event.getHighWatermark());
- //Note: Batch update the timestamps of dataset if the event traffic spike
- datasetConfigManager.updateLastRefreshTime(dataset, event.getHighWatermark());
- ThirdeyeMetricsUtil.processedTriggerEventCounter.inc();
- LOG.info("Finished processing event: " + event.getDatasetName());
+ try {
+ if (checkAllFiltersPassed(event)) {
+ LOG.info("Processing event: " + event.getDatasetName() + " with watermark " + event.getHighWatermark());
+ String dataset = event.getDatasetName();
+ datasetTriggerInfoRepo.setLastUpdateTimestamp(dataset, event.getHighWatermark());
+ //Note: Batch update the timestamps of dataset if the event traffic spike
+ datasetConfigManager.updateLastRefreshTime(dataset, event.getHighWatermark());
+ ThirdeyeMetricsUtil.processedTriggerEventCounter.inc();
+ LOG.info("Finished processing event: " + event.getDatasetName());
Review comment:
Is this log required? can we remove it or turn it to debug level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org