You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/16 22:14:21 UTC

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring

bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367678068
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/DataFileDTO.java
 ##########
 @@ -36,22 +36,22 @@
   @JsonProperty("fileLen")
   private long fileLen;
 
-  public static HoodieDataFile toHoodieDataFile(DataFileDTO dto) {
+  public static HoodieBaseFile toHoodieDataFile(DataFileDTO dto) {
 
 Review comment:
   @vinothchandar Do we want to rename the method as well to 'toHoodieBaseFile' ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services