You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/26 23:04:00 UTC
Review Request 37812: Used linux filesystem isolator by default if
possible.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/
-----------------------------------------------------------
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Repository: mesos
Description
-------
Used linux filesystem isolator by default if possible.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 377de50da90edd64dab812fda3730fa4d7d63b13
Diff: https://reviews.apache.org/r/37812/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 37812: Used linux filesystem isolator by default if
possible.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/#review96603
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37726, 37734, 37735, 37738, 37812]
All tests passed.
- Mesos ReviewBot
On Aug. 26, 2015, 9:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37812/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used linux filesystem isolator by default if possible.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 377de50da90edd64dab812fda3730fa4d7d63b13
>
> Diff: https://reviews.apache.org/r/37812/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37812: Used linux filesystem isolator by default if
possible.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/#review96769
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Aug. 27, 2015, 9:05 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37812/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 9:05 p.m.)
>
>
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used linux filesystem isolator by default if possible.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 377de50da90edd64dab812fda3730fa4d7d63b13
>
> Diff: https://reviews.apache.org/r/37812/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37812: Used linux filesystem isolator by default if
possible.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 9:05 p.m.)
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Added more comments.
Repository: mesos
Description
-------
Used linux filesystem isolator by default if possible.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp 377de50da90edd64dab812fda3730fa4d7d63b13
Diff: https://reviews.apache.org/r/37812/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 37812: Used linux filesystem isolator by default if
possible.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 27, 2015, 12:03 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 145
> > <https://reviews.apache.org/r/37812/diff/1/?file=1055255#file1055255line145>
> >
> > This is quite subtle, I think we should log and also put some documentation around slave that we only choose linux filesystem by default with root.
The logging is already there (see code below): `LOG(INFO) << "Using isolation: " << isolation;`
Adjusted the comments above.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/#review96615
-----------------------------------------------------------
On Aug. 26, 2015, 9:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37812/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used linux filesystem isolator by default if possible.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 377de50da90edd64dab812fda3730fa4d7d63b13
>
> Diff: https://reviews.apache.org/r/37812/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37812: Used linux filesystem isolator by default if
possible.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37812/#review96615
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 145)
<https://reviews.apache.org/r/37812/#comment152206>
This is quite subtle, I think we should log and also put some documentation around slave that we only choose linux filesystem by default with root.
- Timothy Chen
On Aug. 26, 2015, 9:04 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37812/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 9:04 p.m.)
>
>
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used linux filesystem isolator by default if possible.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 377de50da90edd64dab812fda3730fa4d7d63b13
>
> Diff: https://reviews.apache.org/r/37812/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>