[jira] [Commented] (LUCENE-9686) TestDirectIODirectory#testFloatsUnderflow can fail assertion

["Zach Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273351#comment-17273351 ] 

Zach Chen commented on LUCENE-9686:
-----------------------------------

Hi [~julietibs], I took a look at this test failure. The issue is that *DirectIODirectory#readByte* did not explicitly handle the read past EOF case, hence the underlying BufferUnderflowException was raised. I’ve opened a PR to address this. Please let me know if it looks good to you.

> TestDirectIODirectory#testFloatsUnderflow can fail assertion
> ------------------------------------------------------------
>
>                 Key: LUCENE-9686
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9686
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Julie Tibshirani
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Reproduction line:
> {code}
> ./gradlew test --tests TestDirectIODirectory.testFloatsUnderflow -Dtests.seed=73B56EAB13269C91 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=haw-US -Dtests.timezone=America/Inuvik -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> {code}
> I didn't have the chance to look deeply, but it seems like the wrong exception type is being thrown:
> {code:java}
>  junit.framework.AssertionFailedError: Unexpected exception type, expected EOFException but got java.nio.BufferUnderflowException
>         at __randomizedtesting.SeedInfo.seed([73B56EAB13269C91:1FD75ACA1CD83E9C]:0)
>         at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2895)
>         at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2876)
>         at org.apache.lucene.store.BaseDirectoryTestCase.testFloatsUnderflow(BaseDirectoryTestCase.java:291)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org