You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/08/11 21:27:31 UTC
[PR] chore(codeowners): trim stale ownership blocks, reword maps notice [superset]
rusackas opened a new pull request, #43079:
URL: https://github.com/apache/superset/pull/43079
### SUMMARY
Hand-edited trim of `.github/CODEOWNERS`:
- Removed the `/superset/migrations/` (SIP-59 DB migration notify) block.
- Removed the `/superset-frontend/src/components/{Select,MetadataBar,DropdownContainer}/` blocks.
- Removed the `/helm/superset/` block.
- Removed the E2E test blocks (`/superset-frontend/playwright/`, `/superset-frontend/cypress-base/`).
- Removed the `/superset/translations/` block.
- Reworded the maps/GeoJSON notice for clarity (no ownership change there).
Everyone who was a codeowner on a removed block has been requested as a reviewer here so they're aware their notifications on those paths are going away and can object if any of it should stay.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — CODEOWNERS text file only.
### TESTING INSTRUCTIONS
N/A — no code path affected; review the diff in `.github/CODEOWNERS`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(codeowners): trim stale ownership blocks, reword maps notice [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43079:
URL: https://github.com/apache/superset/pull/43079#issuecomment-5259058767
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(codeowners): trim stale ownership blocks, reword maps notice [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43079:
URL: https://github.com/apache/superset/pull/43079#issuecomment-5259300611
<!-- Bito Reply -->
The changes in the `.github/CODEOWNERS` file remove several notification rules for specific directories, such as database migrations, frontend components, Helm charts, E2E tests, and translations. It appears the goal of this PR is to clean up or reduce the number of automated notifications triggered by changes in these areas. If you believe these additional sections are also obsolete or no longer require automated notifications, they could be removed as well to maintain consistency with the cleanup performed in this PR.
**.github/CODEOWNERS**
```
# Notify PMC members of changes to GitHub Actions
/.github/ @villebro @geido @eschutho @rusackas @betodealmeida @nytai @mistercrunch @kgabryje @sha174n @dpgaspar @sadpandajoe @hainenber
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(codeowners): trim stale ownership blocks, reword maps notice [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #43079:
URL: https://github.com/apache/superset/pull/43079#discussion_r3763565057
##########
.github/CODEOWNERS:
##########
Review Comment:
I'm OK with it, but I figured since this was extension-land territory, the people in it might still want to "protect" this area while that work is in flight. @michael-s-molina @villebro @geido @eschutho @kgabryje can weigh in here on whether they want to remove these as well, or leave them for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(codeowners): trim stale ownership blocks, reword maps notice [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43079:
URL: https://github.com/apache/superset/pull/43079#discussion_r3762000547
##########
.github/CODEOWNERS:
##########
Review Comment:
Why not remove these too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(codeowners): trim stale ownership blocks, reword maps notice [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43079:
URL: https://github.com/apache/superset/pull/43079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org