You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/12/21 22:09:14 UTC

Review Request 41614: Declaring a user for anonymous request does not work

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41614/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Myroslav Papirkovskyy.


Bugs: AMBARI-14450
    https://issues.apache.org/jira/browse/AMBARI-14450


Repository: ambari


Description
-------

When setting `api.authenticated.user=admin`, requests with no credentials set receive a 403 error. The expected result is for the request to succeed using the user declared by the `api.authenticated.user` property in the ambari.properties file.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 20ce7fa 
  ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 3e164e0 
  ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 4cab770 

Diff: https://reviews.apache.org/r/41614/diff/


Testing
-------

Manual testing

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas


Re: Review Request 41614: Declaring a user for anonymous request does not work

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41614/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 5:18 p.m.)


Review request for Ambari, Jonathan Hurley and Myroslav Papirkovskyy.


Bugs: AMBARI-14450
    https://issues.apache.org/jira/browse/AMBARI-14450


Repository: ambari


Description
-------

When setting `api.authenticated.user=admin`, requests with no credentials set receive a 403 error. The expected result is for the request to succeed using the user declared by the `api.authenticated.user` property in the ambari.properties file.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 20ce7fa 
  ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 3e164e0 
  ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 4cab770 

Diff: https://reviews.apache.org/r/41614/diff/


Testing (updated)
-------

Manual testing

# Local test results: 

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:03:55.050s
[INFO] Finished at: Mon Dec 21 17:09:48 EST 2015
[INFO] Final Memory: 68M/1465M
[INFO] ------------------------------------------------------------------------

# Jenkins test results: PENDING


Thanks,

Robert Levas


Re: Review Request 41614: Declaring a user for anonymous request does not work

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41614/#review111546
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Dec. 21, 2015, 4:09 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41614/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 4:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-14450
>     https://issues.apache.org/jira/browse/AMBARI-14450
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When setting `api.authenticated.user=admin`, requests with no credentials set receive a 403 error. The expected result is for the request to succeed using the user declared by the `api.authenticated.user` property in the ambari.properties file.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 20ce7fa 
>   ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 3e164e0 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java 4cab770 
> 
> Diff: https://reviews.apache.org/r/41614/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>