You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 17:06:33 UTC
[GitHub] [airflow] benjcabalona1029 opened a new pull request #17687: Docker Operator with docker-socket-proxy
benjcabalona1029 opened a new pull request #17687:
URL: https://github.com/apache/airflow/pull/17687
- Add a new service based on tecnativa/docker-socket-proxy:0.1.1
- Example dag
-
This will fix issues regarding permission on /var/run/docker.sock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17687: Docker Operator with docker-socket-proxy
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17687:
URL: https://github.com/apache/airflow/pull/17687#issuecomment-901272558
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17687: Docker Operator with docker-socket-proxy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17687:
URL: https://github.com/apache/airflow/pull/17687#issuecomment-901282362
This is likely not where you wanted to add those files.. There is a whole documentation with https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html which is likely where you wanted to add that so that it is visible in the documentation - and you also need to make sure that it is somehow linked to the existing documentatiotn. Just adding files without exposing them in the pages, is not useful,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] benjcabalona1029 closed pull request #17687: Docker Operator with docker-socket-proxy
Posted by GitBox <gi...@apache.org>.
benjcabalona1029 closed pull request #17687:
URL: https://github.com/apache/airflow/pull/17687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org