You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/12/21 06:54:44 UTC

Review Request: api_refactoring: annotations for snapshot related commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8737/
-----------------------------------------------------------

Review request for cloudstack and Rohit Yadav.


Description
-------

API Refactoring
1. Refactoring snapshot related commands


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java 9d9c747 
  api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java 53a84d3 
  api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotCmd.java 92e8d38 
  api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotPoliciesCmd.java f3a3baa 
  api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotPoliciesCmd.java e1a6fd6 
  api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java ae152b3 
  api/src/org/apache/cloudstack/api/response/SnapshotPolicyResponse.java 79d4eff 
  api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 1c06b0a 
  api/src/org/apache/cloudstack/api/response/VolumeResponse.java 1c6f4f3 

Diff: https://reviews.apache.org/r/8737/diff/


Testing
-------


Thanks,

Likitha Shetty


Re: Review Request: api_refactoring: annotations for snapshot related commands

Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8737/#review14829
-----------------------------------------------------------


Incorrect CommandType, should be UUID, for all the @Parameter annotation changes.

- Rohit Yadav


On Dec. 21, 2012, 5:54 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8737/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 5:54 a.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> API Refactoring
> 1. Refactoring snapshot related commands
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java 9d9c747 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java 53a84d3 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotCmd.java 92e8d38 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotPoliciesCmd.java f3a3baa 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotPoliciesCmd.java e1a6fd6 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java ae152b3 
>   api/src/org/apache/cloudstack/api/response/SnapshotPolicyResponse.java 79d4eff 
>   api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 1c06b0a 
>   api/src/org/apache/cloudstack/api/response/VolumeResponse.java 1c6f4f3 
> 
> Diff: https://reviews.apache.org/r/8737/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>