You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "AdamGS (via GitHub)" <gi...@apache.org> on 2026/06/12 18:09:23 UTC
[PR] ci: Setup valid Cargo.lock for `depcheck` [datafusion]
AdamGS opened a new pull request, #22933:
URL: https://github.com/apache/datafusion/pull/22933
## Which issue does this PR close?
- Closes #22932
## Rationale for this change
`depcheck` stopped working because an underlying dependency released a non-semver compatible change (its either `time 0.3.48` or one of their dependencies). Because there was no lockfile, it wasn't able to run anymore which effectively blocks CI across the project.
## What changes are included in this PR?
1. Add lockfile to `depcheck`
2. Make sure to run `depcheck` with `--lock` in CI
## Are these changes tested?
Tested locally
## Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Setup valid `Cargo.lock` for `depcheck` to unblock CI [datafusion]
Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #22933:
URL: https://github.com/apache/datafusion/pull/22933#issuecomment-4694240897
I'll retry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Setup valid Cargo.lock for `depcheck` [datafusion]
Posted by "AdamGS (via GitHub)" <gi...@apache.org>.
AdamGS commented on PR #22933:
URL: https://github.com/apache/datafusion/pull/22933#issuecomment-4694135894
I can't seem to reproduce the license check failure, I've tried to reproduce a clear `hawkeye` install on my laptop but nothing fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Setup valid `Cargo.lock` for `depcheck` to unblock CI [datafusion]
Posted by "AdamGS (via GitHub)" <gi...@apache.org>.
AdamGS commented on PR #22933:
URL: https://github.com/apache/datafusion/pull/22933#issuecomment-4698422102
@Jefffrey addressed that in https://github.com/apache/datafusion/pull/22937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Setup valid `Cargo.lock` for `depcheck` to unblock CI [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #22933:
URL: https://github.com/apache/datafusion/pull/22933#issuecomment-4715563472
thanks @AdamGS & @blaginin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Setup valid `Cargo.lock` for `depcheck` to unblock CI [datafusion]
Posted by "AdamGS (via GitHub)" <gi...@apache.org>.
AdamGS commented on PR #22933:
URL: https://github.com/apache/datafusion/pull/22933#issuecomment-4694232788
just realized it just says in the log that's its an HTTP error, just need someone to retry it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Setup valid `Cargo.lock` for `depcheck` to unblock CI [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #22933:
URL: https://github.com/apache/datafusion/pull/22933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org