[GitHub] [kafka] junrao commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

[GitBox <gi...@apache.org>]

junrao commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-956575167


   @ccding : Thanks for reporting the test failure. This brings up a good point. It's kind of weird to ever have recovery point > log end offset. I am thinking that another potential way to fix this is for the flush() call in close() from recovery point to log end offset to be inclusive on both ends. This way, a flush of (log end offset, log end offset) will force a flush since it's needed for flushing the metadata of log end offset. All other flushes will still be exclusive on the right end since they don't need to preserve the metadata on the right end.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org