[GitHub] b-slim commented on a change in pull request #6461: Catch some incorrect method parameter or call argument formatting patterns with checkstyle

[GitBox <gi...@apache.org>]

b-slim commented on a change in pull request #6461: Catch some incorrect method parameter or call argument formatting patterns with checkstyle
URL: https://github.com/apache/incubator-druid/pull/6461#discussion_r225670304
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/curator/discovery/DiscoveryModule.java
 ##########
 @@ -170,17 +170,21 @@ public void configure(Binder binder)
         CURATOR_KEY
     );
 
+    // For some reason the second argument of Key.get() should be Annotation rather than Class, otherwise fails with NPE
 
 Review comment:
   @leventov this is strange, what is the change that is causing this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org