You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/10/19 02:38:55 UTC

[PR] [fix](regression) Pin Variant mode in search document ID test [doris]

airborne12 opened a new pull request, #69248:
URL: https://github.com/apache/doris/pull/69248

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #68758, #69244
   
   Problem Summary: Fuzzy sessions can enable `default_variant_enable_doc_mode` for `test_search_segment_document_ids`. Its table then uses document mode, while the `parse_to_variant()` values do not. INSERT fails with `Conversion from Variant(... enable doc mode = false) to Variant(... enable doc mode = true) is not supported` before the document ID assertions run.
   
   Explicitly disable document mode in this fixture so its V2 and SNII checks do not depend on the inherited session default. This addresses the [NonConcurrent failure in build 1072798](http://43.132.222.7:8111/viewLog.html?buildId=1072798&tab=buildLog).
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - [x] Regression test: used `run-regression-test.sh --run --conf <local-config> -d search -s test_search_segment_document_ids` with JDBC `sessionVariables=default_variant_enable_doc_mode=true`. The original suite failed with the CI conversion error; the patched suite passed all 16 golden checks, eight each for V2 and SNII. The expected output file is unchanged.
       - [x] Manual test: validation used isolated copies of the existing branch-4.2 ASAN FE/BE runtime built for `9c2283cfe1e53f1bd6b7473fa3168125ddf1c359`, with the master suite from this PR. No new kernel build was needed for this Groovy-only change.
   - Behavior changed:
       - [x] No production behavior changes.
   - Does this need documentation?
       - [x] No.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](regression) Pin Variant mode in search document ID test [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69248:
URL: https://github.com/apache/doris/pull/69248#issuecomment-6258615616

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](regression) Pin Variant mode in search document ID test [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69248:
URL: https://github.com/apache/doris/pull/69248#issuecomment-6258476093

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](regression) Pin Variant mode in search document ID test [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #69248:
URL: https://github.com/apache/doris/pull/69248#issuecomment-6258614817

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](regression) Pin Variant mode in search document ID test [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #69248:
URL: https://github.com/apache/doris/pull/69248


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org