You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ZacharyThomas <gi...@git.apache.org> on 2017/08/16 16:26:10 UTC
[GitHub] storm pull request #2280: STORM-2500: remove call to waitUntilReady
GitHub user ZacharyThomas opened a pull request:
https://github.com/apache/storm/pull/2280
STORM-2500: remove call to waitUntilReady
In 1.1.x PacemakerClient was refactored so waitUntilReady was private, and called by the send method. But this clojure reference remained, causing pacemaker to fail to initialize. AFAIK this reference can simply be removed, as waitForReady is called on send. However, I'm not very familiar with the code base. I applied this patch to our own cluster with success.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ZacharyThomas/storm 1.1.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2280
----
commit c82c849efadba5ef4219950bd9c8a3015ae6d34b
Author: Zachary.smith <za...@yodle.com>
Date: 2017-08-16T16:21:11Z
STORM-2500: remove call to waitUntilReady
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2280: STORM-2500: remove call to waitUntilReady
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2280
@ZacharyThomas
Thanks for the patch. I merged this but can't update assignee on issue (https://issues.apache.org/jira/browse/STORM-2500).
Could you let me know your Apache JIRA ID? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady
Posted by ZacharyThomas <gi...@git.apache.org>.
Github user ZacharyThomas commented on the issue:
https://github.com/apache/storm/pull/2280
@HeartSaVioR It was fun. Encountered this while trying to debug the exclamation topology dying on a new cluster (see: https://mail-archives.apache.org/mod_mbox/storm-user/201708.mbox/%3CCA%2BAmaO0oP5imSgs7nXboM_VQva0PzoQNGGURG%2BfR3rySystm1g%40mail.gmail.com%3E)
Which, if you have any suggestions for, that'd be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2280
@ZacharyThomas Just updated. Thanks again for contributing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2280
+1
This fixes what #2142 already fixed, but no activity is seen on #2142 I'll just merge this.
Travis CI fails on all JDK7 builds, hence not related to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2280: STORM-2500: remove call to waitUntilReady
Posted by ZacharyThomas <gi...@git.apache.org>.
Github user ZacharyThomas commented on the issue:
https://github.com/apache/storm/pull/2280
@HeartSaVioR Thanks for the merge. My username on jira should be actking. Sorry I couldn't find anywhere to set assignee on Jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---