You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "yuanming24 (via GitHub)" <gi...@apache.org> on 2024/05/28 09:50:50 UTC
[I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
yuanming24 opened a new issue, #16084:
URL: https://github.com/apache/dolphinscheduler/issues/16084
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
When editing the alarm instance, the port has not been modified. Clicking OK will prompt `serverPort is not a number`.
### What you expected to happen
When parsing to obtain json containing alarm instance information from the backend, the port should be converted to number type
### How to reproduce
1. Editing an alarm instance whitch has port field
2. Click submit button
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on issue #16084:
URL: https://github.com/apache/dolphinscheduler/issues/16084#issuecomment-2136697435
@rockfang Would you like to fix this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
Posted by "yuanming24 (via GitHub)" <gi...@apache.org>.
yuanming24 commented on issue #16084:
URL: https://github.com/apache/dolphinscheduler/issues/16084#issuecomment-2138508316
@rockfang Agree with u!
@ruanwenjun I unassined me. You can assign @rockfang and use PR #16089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
Posted by "rockfang (via GitHub)" <gi...@apache.org>.
rockfang commented on issue #16084:
URL: https://github.com/apache/dolphinscheduler/issues/16084#issuecomment-2136667764
I found this problem too.
Here is the reason:
1. frontend submit `serverPort` field value type is **number**.when creating an alert-instance by `alert-plugin-instances` api
2. frontend query alert plugin instances by `alert-plugin-instances?pageNo=1&pageSize=10` api. `serverPort` field value type becomes to **string**
3. the data in the database is string
conclusion：the number type data changed to string when backend processing it.
My solution:
**原因分析：**
1. 前端创建实例时提交的serverPort字段值是数字
2. 查询实例列表时，解析出的serverPort字段值编程了字符串
3. 实际库中存的是字符串
结论：后端在处理告警实例参数时，把数字类型的序列化成了字符串存储
**我的解决方案：**
A: 后端针对这些number类型字段保存为json时要确保类型依然是number
B: 前端拿到数据自行处理
**针对方式B, 后端代码不变，前端如何处理**？
统一把字段信息中type为`number`的条目，把value手动转成number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
Posted by "rockfang (via GitHub)" <gi...@apache.org>.
rockfang commented on issue #16084:
URL: https://github.com/apache/dolphinscheduler/issues/16084#issuecomment-2136744242
@SbloodyS @yuanming24 I put a PR to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on issue #16084:
URL: https://github.com/apache/dolphinscheduler/issues/16084#issuecomment-2137149108
I cannot reproduce this @rockfang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [AlertInstance Manage] verification exception when editing alarm instance [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #16084: [Bug] [AlertInstance Manage] verification exception when editing alarm instance
URL: https://github.com/apache/dolphinscheduler/issues/16084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org