[GitHub] [wicket] theigl commented on a diff in pull request #512: List.of() creates an immutable List instance, without a backing Array...

[GitBox <gi...@apache.org>]

theigl commented on code in PR #512:
URL: https://github.com/apache/wicket/pull/512#discussion_r852819547


##########
wicket-core/src/main/java/org/apache/wicket/Component.java:
##########
@@ -2669,7 +2669,7 @@ public void internalRenderHead(final HtmlHeaderContainer container)
 					if (response.wasRendered(behavior) == false)

Review Comment:
   The change itself looks good to me, but I'm wondering if the code is currently working as expected. We mark a pair of Component+Behavior as rendered, but the check if a behavior was already rendered only tests for the behavior itself.
   
   @martin-g: You originally introduced this to fix https://issues.apache.org/jira/browse/WICKET-4570 many years ago. Could it be that you forgot to adjust the `wasRendered` condition? Imho the current code will never return `true` for `response.wasRendered(behavior)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org