You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/14 21:16:50 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
rkhachatryan opened a new pull request #13642:
URL: https://github.com/apache/flink/pull/13642
## What is the purpose of the change
*Remove duplicated `PipelinedSubpartition.addBufferConsumer` method and use `PipelinedSubpartition.add()` instead.*
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708665953
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 04f8d715a9a672b0d832e9b9e067294376eae211 (Wed Oct 14 21:19:06 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #13642:
URL: https://github.com/apache/flink/pull/13642#discussion_r505423014
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java
##########
@@ -101,7 +101,10 @@ private RecoveredInputChannel getChannel(InputChannelInfo info) {
public void recover(ResultSubpartitionInfo subpartitionInfo, Tuple2<BufferBuilder, BufferConsumer> bufferBuilderAndConsumer) {
bufferBuilderAndConsumer.f0.finish();
if (bufferBuilderAndConsumer.f1.isDataAvailable()) {
- getSubpartition(subpartitionInfo).addBufferConsumer(bufferBuilderAndConsumer.f1);
+ boolean added = getSubpartition(subpartitionInfo).add(bufferBuilderAndConsumer.f1);
+ if (!added) {
+ throw new RuntimeException("Buffer consumer couldn't be added to ResultSubpartition");
Review comment:
`false` is returned if the subpartition `isFinished || isReleased`. This case seems to me neither IO error nor recoverable.
I can change to `IOException` though if you insist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708975509
CI failure unrelated (FLINK-19469).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634)
* 0a808e97a4bd54c56e3b3eeb52d2c73b45366a34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7679",
"triggerID" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0a808e97a4bd54c56e3b3eeb52d2c73b45366a34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7679)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #13642:
URL: https://github.com/apache/flink/pull/13642#discussion_r505405128
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java
##########
@@ -101,7 +101,10 @@ private RecoveredInputChannel getChannel(InputChannelInfo info) {
public void recover(ResultSubpartitionInfo subpartitionInfo, Tuple2<BufferBuilder, BufferConsumer> bufferBuilderAndConsumer) {
bufferBuilderAndConsumer.f0.finish();
if (bufferBuilderAndConsumer.f1.isDataAvailable()) {
- getSubpartition(subpartitionInfo).addBufferConsumer(bufferBuilderAndConsumer.f1);
+ boolean added = getSubpartition(subpartitionInfo).add(bufferBuilderAndConsumer.f1);
+ if (!added) {
+ throw new RuntimeException("Buffer consumer couldn't be added to ResultSubpartition");
Review comment:
`IOException`? (`org.apache.flink.runtime.checkpoint.channel.ChannelStateChunkReader#readChunk` already can handle `IOException`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #13642:
URL: https://github.com/apache/flink/pull/13642#discussion_r505449067
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java
##########
@@ -101,7 +101,10 @@ private RecoveredInputChannel getChannel(InputChannelInfo info) {
public void recover(ResultSubpartitionInfo subpartitionInfo, Tuple2<BufferBuilder, BufferConsumer> bufferBuilderAndConsumer) {
bufferBuilderAndConsumer.f0.finish();
if (bufferBuilderAndConsumer.f1.isDataAvailable()) {
- getSubpartition(subpartitionInfo).addBufferConsumer(bufferBuilderAndConsumer.f1);
+ boolean added = getSubpartition(subpartitionInfo).add(bufferBuilderAndConsumer.f1);
+ if (!added) {
+ throw new RuntimeException("Buffer consumer couldn't be added to ResultSubpartition");
Review comment:
I suggested `IOException` because that's what was in the signature of the parent/caller method.
Maybe alternatively `CancelTaskException`, but I'm not entirely sure if that's always the case (what if there was some error in this task, that caused the partition to be released?)
What adds to my confusion is that this return value is ignored in rest of the code base? 🤷♂️
I think for now it would be the best to go with `IOException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #13642:
URL: https://github.com/apache/flink/pull/13642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708972619
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #13642:
URL: https://github.com/apache/flink/pull/13642#discussion_r505453438
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java
##########
@@ -101,7 +101,10 @@ private RecoveredInputChannel getChannel(InputChannelInfo info) {
public void recover(ResultSubpartitionInfo subpartitionInfo, Tuple2<BufferBuilder, BufferConsumer> bufferBuilderAndConsumer) {
bufferBuilderAndConsumer.f0.finish();
if (bufferBuilderAndConsumer.f1.isDataAvailable()) {
- getSubpartition(subpartitionInfo).addBufferConsumer(bufferBuilderAndConsumer.f1);
+ boolean added = getSubpartition(subpartitionInfo).add(bufferBuilderAndConsumer.f1);
+ if (!added) {
+ throw new RuntimeException("Buffer consumer couldn't be added to ResultSubpartition");
Review comment:
Changed to `IOException`.
> What adds to my confusion is that this return value is ignored in rest of the code base?
I agree, but I think it can be addressed separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7679",
"triggerID" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634)
* 0a808e97a4bd54c56e3b3eeb52d2c73b45366a34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7679)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "708972619",
"triggerType" : "MANUAL"
}, {
"hash" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7679",
"triggerID" : "0a808e97a4bd54c56e3b3eeb52d2c73b45366a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7660) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634)
* 0a808e97a4bd54c56e3b3eeb52d2c73b45366a34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7679)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13642:
URL: https://github.com/apache/flink/pull/13642#issuecomment-708668367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634",
"triggerID" : "04f8d715a9a672b0d832e9b9e067294376eae211",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04f8d715a9a672b0d832e9b9e067294376eae211 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7634)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org