You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/18 14:27:48 UTC
[GitHub] [camel] rnetuka opened a new pull request, #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
rnetuka opened a new pull request, #8571:
URL: https://github.com/apache/camel/pull/8571
Issue: https://issues.apache.org/jira/browse/CAMEL-18612
Please, check that I didn't miss any place to inlude/support the new _unpackArray_ option.
Also, the option name is only a proposal. Another proposals are:
- unwrapSingleArray (original)
- unwrapArray
- unwrapSingleElements
- unpackSingleArray
- unpackArray
- unpackSingleElements
Which is the best?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1282493398
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1282607592
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283846812
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 19 | 19 | 2 | 18 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283787469
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 19 | 19 | 2 | 18 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #8571:
URL: https://github.com/apache/camel/pull/8571#discussion_r998418320
##########
components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/JsonPathLanguage.java:
##########
@@ -134,8 +140,9 @@ public Expression createExpression(String expression, Object[] properties) {
answer.setAllowSimple(property(boolean.class, properties, 2, allowSimple));
answer.setAllowEasyPredicate(property(boolean.class, properties, 3, allowEasyPredicate));
answer.setWriteAsString(property(boolean.class, properties, 4, writeAsString));
- answer.setHeaderName(property(String.class, properties, 5, headerName));
- String option = (String) properties[6];
+ answer.setWriteAsString(property(boolean.class, properties, 5, unpackArray));
Review Comment:
setUnpackArray
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] rnetuka commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
rnetuka commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283681440
@davsclaus What about https://github.com/apache/camel/blob/main/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClause.java#L466 and https://github.com/apache/camel/blob/main/core/camel-core-model/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java#L477?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283837349
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 19 | 19 | 3 | 17 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283839885
Yeah ideally we need a new method in those java-dsl classes to expose this new option. However its likely seldom in use, so you can just add 1 new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283953133
:leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (24 components likely to be affected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8571:
URL: https://github.com/apache/camel/pull/8571#issuecomment-1283679243
Have you updated `JsonPathExpressionReifier` also with the new option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8571: [CAMEL-18612] Inconsistency in JsonPath component causes problems with databinding
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8571:
URL: https://github.com/apache/camel/pull/8571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org