You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2025/04/12 12:43:39 UTC
[PR] Add DialectDatabaseMetaData.isSupportAutoCommitInNestedTransaction [shardingsphere]
terrymanu opened a new pull request, #35170:
URL: https://github.com/apache/shardingsphere/pull/35170
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DialectDatabaseMetaData.isSupportAutoCommitInNestedTransaction [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #35170:
URL: https://github.com/apache/shardingsphere/pull/35170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DialectDatabaseMetaData.isSupportAutoCommitInNestedTransaction [shardingsphere]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #35170:
URL: https://github.com/apache/shardingsphere/pull/35170#discussion_r2040650626
##########
infra/database/core/src/main/java/org/apache/shardingsphere/infra/database/core/metadata/database/DialectDatabaseMetaData.java:
##########
@@ -148,6 +148,15 @@ default boolean isDDLNeedImplicitCommit() {
return false;
}
+ /**
+ * Whether support auto commit when nested transaction.
Review Comment:
[nitpick] Consider updating the Javadoc to improve clarity and grammar, for example: "Whether to support auto-commit in nested transactions."
```suggestion
* Whether to support auto-commit in nested transactions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org