You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/27 20:44:13 UTC
[Impala-ASF-CR](asf-site) Add downloads page
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4544
Change subject: Add downloads page
......................................................................
Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 185 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4544/1
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html
File downloads.html:
PS1, Line 135: class="active"
This is not the item that should be active. (It should be downloads)
Line 142: <p><a href=
It would probably be a good idea to put <h2>Downloads</h2> above this line to be consistent with other pages.
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 4:
(5 comments)
I used
tidy -indent --wrap 90 -bare
in PS1, FYI.
http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html
File downloads.html:
PS1, Line 50: /* Cu
> indent off
Done
PS1, Line 90: </scrip
> can you align this with <script> ?
Done
Line 141: <div class="span12">
> Would be nicer looking to have a blank line here.
Added title on separate line.
PS1, Line 159: sign
> This one and the <hr> at line 162 seem to duplicate or is it how we usually
half the time it's two <hr>s, half one.
I made this one one.
http://gerrit.cloudera.org:8080/#/c/4544/1/impala-docs.html
File impala-docs.html:
PS1, Line 48:
> tab
removed
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-3808: Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-3808: Add downloads page
......................................................................
IMPALA-3808: Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Reviewed-on: http://gerrit.cloudera.org:8080/4544
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Jim Apple <jb...@cloudera.com>
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 187 insertions(+), 2 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4544
to look at the new patch set (#5).
Change subject: Add downloads page
......................................................................
Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 187 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4544/5
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4544/4/downloads.html
File downloads.html:
PS4, Line 174: <!-- /container -->
> Not sure if it's actually aligning correctly here ?
removed
http://gerrit.cloudera.org:8080/#/c/4544/4/index.html
File index.html:
PS4, Line 48:
> tab.
OK, I fixed this, but I think we should abbreviate the process of beautifying all of the other HTML files. I don't think it's worth our time.
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 5: Code-Review+2
Looks good to me. We should verify that the download links are working before actually pushing.
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-3808: Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Taras Bobrovytsky, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4544
to look at the new patch set (#6).
Change subject: IMPALA-3808: Add downloads page
......................................................................
IMPALA-3808: Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 187 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4544/6
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html
File downloads.html:
PS1, Line 135: class="active"
> This is not the item that should be active. (It should be downloads)
Nice catch.
Line 142: <p><a href=
> It would probably be a good idea to put <h2>Downloads</h2> above this line
Done
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Please wait for +2 from Taras.
http://gerrit.cloudera.org:8080/#/c/4544/4/downloads.html
File downloads.html:
PS4, Line 174: <!-- /container -->
Not sure if it's actually aligning correctly here ?
http://gerrit.cloudera.org:8080/#/c/4544/4/index.html
File index.html:
PS4, Line 48:
tab.
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-3808: Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3808: Add downloads page
......................................................................
Patch Set 6: Code-Review+2
Just changed commit message, carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: Add downloads page
......................................................................
Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 185 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4544/2
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#3).
Change subject: Add downloads page
......................................................................
Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 185 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4544/3
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html
File downloads.html:
PS1, Line 50:
indent off
PS1, Line 90: </script>
can you align this with <script> ?
Line 141: <div class="span12">
Would be nicer looking to have a blank line here.
PS1, Line 159: <hr>
This one and the <hr> at line 162 seem to duplicate or is it how we usually format it ?
http://gerrit.cloudera.org:8080/#/c/4544/1/impala-docs.html
File impala-docs.html:
PS1, Line 48:
tab
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-3808: Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3808: Add downloads page
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#4).
Change subject: Add downloads page
......................................................................
Add downloads page
This should not be pushed to the repo until a release is approved by
the IPMC and the links are working and the mirrors have 24 hours to
catch up.
Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
---
M community.html
A downloads.html
M impala-docs.html
M index.html
M overview.html
5 files changed, 186 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4544/4
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR](asf-site) Add downloads page
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Add downloads page
......................................................................
Patch Set 5: Code-Review+1
Carry kwho@'s +1
--
To view, visit http://gerrit.cloudera.org:8080/4544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I100a4640d0a7c149ee87246d14248e4857d31d75
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No