You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/22 00:22:34 UTC
Review Request 56908: ATLAS-1571: fix for incorrect v1->v2 conversion
of enum-type value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56908/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1571
https://issues.apache.org/jira/browse/ATLAS-1571
Repository: atlas
Description
-------
Format converter expected enum value to be provided in v1; but the value from Hive notification was the ordinal. Updated the converter to handle the following 3 types of values for enum: 1) EnumValue 2) Map 3) Ordinal 4) Value
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java db169d0
repository/src/main/java/org/apache/atlas/repository/converters/AtlasEnumFormatConverter.java 2bf15f2
Diff: https://reviews.apache.org/r/56908/diff/
Testing
-------
Verified that hive_db.ownerType value given in the notification is saved and is available on entity retrieval.
Thanks,
Madhan Neethiraj
Re: Review Request 56908: ATLAS-1571: fix for incorrect v1->v2
conversion of enum-type value
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56908/#review166278
-----------------------------------------------------------
Ship it!
- Ashutosh Mestry
On Feb. 22, 2017, 12:22 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56908/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 12:22 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1571
> https://issues.apache.org/jira/browse/ATLAS-1571
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Format converter expected enum value to be provided in v1; but the value from Hive notification was the ordinal. Updated the converter to handle the following 3 types of values for enum: 1) EnumValue 2) Map 3) Ordinal 4) Value
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java db169d0
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasEnumFormatConverter.java 2bf15f2
>
> Diff: https://reviews.apache.org/r/56908/diff/
>
>
> Testing
> -------
>
> Verified that hive_db.ownerType value given in the notification is saved and is available on entity retrieval.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>