You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/30 17:56:33 UTC
[GitHub] [arrow] felipeblazing commented on a change in pull request #10843: ARROW-4700: [C++] Added support for decimal128 and decimal256 json converted
felipeblazing commented on a change in pull request #10843:
URL: https://github.com/apache/arrow/pull/10843#discussion_r680124458
##########
File path: cpp/src/arrow/json/converter_test.cc
##########
@@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) {
AssertConvert(timestamp(TimeUnit::SECOND), src, src);
}
+TEST(ConverterTest, Decimal128) {
+ std::string src = R"([
+ "02.0000000000",
+ "30.0000000000",
+ "22.0000000000",
+ "-121.0000000000",
+ null])";
+
+ AssertConvert(decimal128(38, 10), src, src);
Review comment:
How does this verify that the value was converted to the correct value if we aren't passing in a decimal128 with the correct value specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org