You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/09 12:36:00 UTC
[jira] [Commented] (AIRFLOW-2781) SLA Usage
[ https://issues.apache.org/jira/browse/AIRFLOW-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574780#comment-16574780 ]
ASF GitHub Bot commented on AIRFLOW-2781:
-----------------------------------------
XD-DENG opened a new pull request #3724: [AIRFLOW-2781] Fix www_rbac display issue
URL: https://github.com/apache/incubator-airflow/pull/3724
### Jira
- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-2781
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
The RBAC UI has some issues about layout/UI display.
The header (`<h2>`) is not shown ("hidden" by the Nav Bar), or tables are not shown completely.
This is addressed by a simple change on `templates/appbuilder/baselayout.html`.
`**Please check the screenshots below**` (like beforeFix-1 vs. afterFix-1, beforeFix-2 vs. afterFix-2, etc)..
### **Screenshots - Before Fix**
##### beforeFix-1
<img width="981" alt="screen shot 2018-08-09 at 8 11 14 pm" src="https://user-images.githubusercontent.com/11539188/43898798-88b35454-9c12-11e8-9ffb-7aafccac5662.png">
##### beforeFix-2
<img width="1041" alt="screen shot 2018-08-09 at 8 10 45 pm" src="https://user-images.githubusercontent.com/11539188/43898796-883b2b8c-9c12-11e8-9e71-97c5d86aedf6.png">
##### beforeFix-3
<img width="1025" alt="screen shot 2018-08-09 at 8 10 03 pm" src="https://user-images.githubusercontent.com/11539188/43898797-88865a44-9c12-11e8-8d87-40afcc5e33e9.png">
##### beforeFix-4
<img width="987" alt="screen shot 2018-08-09 at 8 11 08 pm" src="https://user-images.githubusercontent.com/11539188/43898799-88dd8576-9c12-11e8-9277-111c75bfd9b8.png">
### **Screenshots - After Fix**
##### afterFix-1
<img width="1160" alt="screen shot 2018-08-09 at 8 14 33 pm" src="https://user-images.githubusercontent.com/11539188/43898848-af9080ba-9c12-11e8-9b38-6c1a3c7981bc.png">
##### afterFix-2
<img width="930" alt="screen shot 2018-08-09 at 8 14 45 pm" src="https://user-images.githubusercontent.com/11539188/43898953-0bc403e8-9c13-11e8-9cd0-05a4108273e2.png">
##### afterFix-3
<img width="1438" alt="screen shot 2018-08-09 at 8 14 19 pm" src="https://user-images.githubusercontent.com/11539188/43898850-aff09572-9c12-11e8-893a-4773907c84eb.png">
##### afterFix-4
<img width="1063" alt="screen shot 2018-08-09 at 8 14 27 pm" src="https://user-images.githubusercontent.com/11539188/43898849-afc46e34-9c12-11e8-99c1-320d88139ce5.png">
##### afterFix-5
<img width="1431" alt="screen shot 2018-08-09 at 8 14 39 pm" src="https://user-images.githubusercontent.com/11539188/43898852-b048ba22-9c12-11e8-8cb1-17abb939b601.png">
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
### Code Quality
- [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> SLA Usage
> ---------
>
> Key: AIRFLOW-2781
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2781
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration
> Affects Versions: 1.9.0
> Reporter: Xiaodong DENG
> Priority: Minor
>
> Hi, the documentation or information about SLA is quite limited.
> I'm trying to up SLA for my DAGs, but it's not working as I expected/assumed.
> One example is
> {code:java}
> // https://github.com/DFStoneburner/airflow-sla-examples/blob/master/basic_sla.py
> t1 = BashOperator(
> task_id='timeout',
> # Set our task up with a 10 second SLA
> sla=timedelta(seconds=10),
> # Sleep 15 seconds to guarantee we miss the SLA
> bash_command='sleep 15',
> dag=dag
> )
> {code}
> Actually I don't see any record in "*Browse -> SLA Misses*" even if this DAG can run on schedule.
> For my specific scenario, let's say my schedule interval of the DAG is `_0 3 * * *`_ (3AM in the morning),
> * if I expect my task is succeeded by 3:30AM, I set `*sla=timedelta(minutes=30)*`.
> * if I expect my task is succeeded by 3AM or earlier, I set `*sla=timedelta(seconds=0)*`.
> But seems it's not working as I assumed.
>
> May any one kindly advise on this? Thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)