You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sryza (via GitHub)" <gi...@apache.org> on 2025/06/08 02:25:31 UTC
[PR] Fix MaterializeTablesSuite in Maven [spark]
sryza opened a new pull request, #51112:
URL: https://github.com/apache/spark/pull/51112
### What changes were proposed in this pull request?
Fixes the issue identified here: https://github.com/apache/spark/pull/51050#discussion_r2133923514
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
```
build/mvn clean install -DskipTests -pl sql/pipelines -am
build/mvn test -pl sql/pipelines
```
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix MaterializeTablesSuite in Maven [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on code in PR #51112:
URL: https://github.com/apache/spark/pull/51112#discussion_r2134356416
##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/utils/PipelineTest.scala:
##########
@@ -50,8 +50,6 @@ abstract class PipelineTest
final protected val storageRoot = createTempDir()
var spark: SparkSession = createAndInitializeSpark()
Review Comment:
BTW why not use the `SharedSparkSession` trait?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52346][SQL][FOLLOW-UP] Fix MaterializeTablesSuite in Maven [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on code in PR #51112:
URL: https://github.com/apache/spark/pull/51112#discussion_r2134964582
##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/MaterializeTablesSuite.scala:
##########
@@ -33,10 +33,10 @@ import org.apache.spark.util.Utils.exceptionString
* tables are written with the appropriate schemas.
*/
class MaterializeTablesSuite extends BaseCoreExecutionTest {
-
- import originalSpark.implicits._
-
test("basic") {
+ val session = spark
+ import session.implicits._
Review Comment:
Cool, I will merge it to unblock the build failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52346][SQL][FOLLOW-UP] Fix MaterializeTablesSuite in Maven [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #51112:
URL: https://github.com/apache/spark/pull/51112#issuecomment-2954519110
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix MaterializeTablesSuite in Maven [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #51112:
URL: https://github.com/apache/spark/pull/51112#discussion_r2134560423
##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/utils/PipelineTest.scala:
##########
@@ -50,8 +50,6 @@ abstract class PipelineTest
final protected val storageRoot = createTempDir()
var spark: SparkSession = createAndInitializeSpark()
Review Comment:
+1 for reuse `SharedSparkSession `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix MaterializeTablesSuite in Maven [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on code in PR #51112:
URL: https://github.com/apache/spark/pull/51112#discussion_r2134778462
##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/MaterializeTablesSuite.scala:
##########
@@ -33,10 +33,10 @@ import org.apache.spark.util.Utils.exceptionString
* tables are written with the appropriate schemas.
*/
class MaterializeTablesSuite extends BaseCoreExecutionTest {
-
- import originalSpark.implicits._
-
test("basic") {
+ val session = spark
+ import session.implicits._
Review Comment:
do we still need these changes after using `SharedSparkSession`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Fix MaterializeTablesSuite in Maven [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on code in PR #51112:
URL: https://github.com/apache/spark/pull/51112#discussion_r2134829061
##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/MaterializeTablesSuite.scala:
##########
@@ -33,10 +33,10 @@ import org.apache.spark.util.Utils.exceptionString
* tables are written with the appropriate schemas.
*/
class MaterializeTablesSuite extends BaseCoreExecutionTest {
-
- import originalSpark.implicits._
-
test("basic") {
+ val session = spark
+ import session.implicits._
Review Comment:
It appears that we still do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52346][SQL][FOLLOW-UP] Fix MaterializeTablesSuite in Maven [spark]
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang closed pull request #51112: [SPARK-52346][SQL][FOLLOW-UP] Fix MaterializeTablesSuite in Maven
URL: https://github.com/apache/spark/pull/51112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org