[GitHub] [hudi] Trevor-zhang commented on a change in pull request #1779: [HUDI-1062]Remove unnecessary maxEvent check and add some log in KafkaOffsetGen

[GitBox <gi...@apache.org>]

Trevor-zhang commented on a change in pull request #1779:
URL: https://github.com/apache/hudi/pull/1779#discussion_r449731135



##########
File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestKafkaSource.java
##########
@@ -191,13 +191,13 @@ public void testJsonKafkaSourceWithDefaultUpperCap() {
      */
     testUtils.sendMessages(TEST_TOPIC_NAME, Helpers.jsonifyRecords(dataGenerator.generateInserts("000", 1000)));
     InputBatch<JavaRDD<GenericRecord>> fetch1 = kafkaSource.fetchNewDataInAvroFormat(Option.empty(), Long.MAX_VALUE);
-    assertEquals(500, fetch1.getBatch().get().count());
+    assertEquals(1000, fetch1.getBatch().get().count());

Review comment:
       > why exactly does this test have to change? could you please clarify
   hi @vinothchandar,  the value of `maxEventsToReadFromKafka `has changed in this commit, so the value of `fetch1.getBatch().get().count() `also changes in the test case.
   
   > there is an empty `git` file in this commit.. can you please remove this?
   @vinothchandar I hive removed this file.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org