You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2018/01/12 19:49:20 UTC
[GitHub] andymc12 commented on a change in pull request #366: Handle ResponseExceptionMappers
andymc12 commented on a change in pull request #366: Handle ResponseExceptionMappers
URL: https://github.com/apache/cxf/pull/366#discussion_r161310983
##########
File path: rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientProviderFactory.java
##########
@@ -91,16 +91,11 @@ protected void setProviders(boolean custom, boolean busGlobal, Object... provide
public List<ResponseExceptionMapper<?>> createResponseExceptionMapper(Message m, Class<?> paramType) {
- List<ResponseExceptionMapper<?>> candidates = new LinkedList<>();
-
- for (ProviderInfo<ResponseExceptionMapper<?>> em : responseExceptionMappers) {
- if (handleMapper(em, paramType, m, ResponseExceptionMapper.class, true)) {
- candidates.add(em.getProvider());
- }
- }
- if (candidates.size() == 0) {
+ if (responseExceptionMappers.isEmpty()) {
return Collections.emptyList();
}
+ List<ResponseExceptionMapper<?>> candidates =
Review comment:
@reta - thanks for the suggestion - I'm making that change and squashing now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services