You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/03/28 05:32:12 UTC
Review Request 32593: DRILL-2579: pt 1. Core fix: Fix: JDBC unit
tests will time out after one testcase fails with unexpected results.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32593/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Repository: drill-git
Description
-------
Nulled out member to avoid re-using closed Connection.
Diffs
-----
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
Diff: https://reviews.apache.org/r/32593/diff/
Testing
-------
Manual: Broke a JDBC JUnit test, ran it, saw hang, applied fix line, ran again, saw hang gone.
Ran existing tests.
Thanks,
Daniel Barclay
Re: Review Request 32593: DRILL-2579: pt 1. Core fix: Fix: JDBC unit
tests will time out after one testcase fails with unexpected results.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32593/#review78384
-----------------------------------------------------------
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java
<https://reviews.apache.org/r/32593/#comment126989>
Ping?
- Daniel Barclay
On March 28, 2015, 4:32 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32593/
> -----------------------------------------------------------
>
> (Updated March 28, 2015, 4:32 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Nulled out member to avoid re-using closed Connection.
>
>
> Diffs
> -----
>
> exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
>
> Diff: https://reviews.apache.org/r/32593/diff/
>
>
> Testing
> -------
>
> Manual: Broke a JDBC JUnit test, ran it, saw hang, applied fix line, ran again, saw hang gone.
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 32593: DRILL-2579: pt 1. Core fix: Fix: JDBC unit
tests will time out after one testcase fails with unexpected results.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32593/#review78727
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On March 31, 2015, 9:32 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32593/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 9:32 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2579
> https://issues.apache.org/jira/browse/DRILL-2579
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Nulled out member to avoid re-using closed Connection.
>
>
> Diffs
> -----
>
> exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
>
> Diff: https://reviews.apache.org/r/32593/diff/
>
>
> Testing
> -------
>
> Manual: Broke a JDBC JUnit test, ran it, saw hang, applied fix line, ran again, saw hang gone.
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 32593: DRILL-2579: pt 1. Core fix: Fix: JDBC unit
tests will time out after one testcase fails with unexpected results.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32593/
-----------------------------------------------------------
(Updated March 31, 2015, 9:32 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2579
https://issues.apache.org/jira/browse/DRILL-2579
Repository: drill-git
Description
-------
Nulled out member to avoid re-using closed Connection.
Diffs
-----
exec/jdbc/src/test/java/org/apache/drill/jdbc/SingleConnectionCachingFactory.java 88fb4c6
Diff: https://reviews.apache.org/r/32593/diff/
Testing
-------
Manual: Broke a JDBC JUnit test, ran it, saw hang, applied fix line, ran again, saw hang gone.
Ran existing tests.
Thanks,
Daniel Barclay