[GitHub] [arrow] westonpace commented on a change in pull request #11358: ARROW-12820: [C++] Support zone offset in ISO8601, strptime parser

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #11358:
URL: https://github.com/apache/arrow/pull/11358#discussion_r725218714



##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -1429,6 +1430,17 @@ TYPED_TEST(TestStringKernels, Strptime) {
   this->CheckUnary("strptime", input1, timestamp(TimeUnit::MICRO), output1, &options);
 }
 
+TYPED_TEST(TestStringKernels, StrptimeZoneOffset) {
+  if (!arrow::internal::kStrptimeSupportsZone) {
+    GTEST_SKIP() << "strptime does not support %z on this platform";
+  }
+  std::string input1 = R"(["5/1/2020 +01", null, "12/11/1900 -01:30"])";
+  std::string output1 =
+      R"(["2020-04-30T23:00:00.000000", null, "1900-12-11T01:30:00.000000"])";
+  StrptimeOptions options("%m/%d/%Y %z", TimeUnit::MICRO);
+  this->CheckUnary("strptime", input1, timestamp(TimeUnit::MICRO), output1, &options);

Review comment:
       The ISO8601 parser currently both allows Z and allows the Z to be missing so it can parse both 2020-01-01T12:00:00 and 2020-01-01T12:00:00Z (even in the same array).
   
   So basically, in the ISO8601 case, there is no %z to input from the user.
   
   Are you saying the places that use the parser should check to see if every parsed timestamp used Z and return UTC in that case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org