[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1061625026


##########
solr/modules/opentelemetry/build.gradle:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'Open Telemetry (OTEL) tracer'
+
+// This is a hacky way to use permitTestUnusedDeclared with bom declared dependencies.
+// See https://github.com/gradle-dependency-analyze/gradle-dependency-analyze/issues/108
+configurations {
+  constraintsOnly
+  permitUnusedDeclared.extendsFrom constraintsOnly
+  implementation.extendsFrom constraintsOnly
+}
+
+dependencies {
+  implementation project(':solr:core')
+
+  constraintsOnly(platform('io.opentelemetry:opentelemetry-bom-alpha'))
+
+  implementation 'io.opentracing:opentracing-api'
+  implementation 'org.slf4j:slf4j-api'
+
+  implementation 'io.opentelemetry:opentelemetry-sdk'
+  implementation 'io.opentelemetry:opentelemetry-sdk-trace'
+  implementation 'io.opentelemetry:opentelemetry-sdk-extension-autoconfigure'
+  implementation 'io.opentelemetry:opentelemetry-opentracing-shim'
+  implementation 'io.opentelemetry:opentelemetry-semconv'

Review Comment:
   Are these actually `implementation`? RuntimeOnly might work? Especially since these are permit unused declared?
   
   The same goes for the grpc stuff below.



##########
versions.props:
##########
@@ -20,8 +20,10 @@ commons-codec:commons-codec=1.15
 commons-collections:commons-collections=3.2.2
 commons-io:commons-io=2.11.0
 io.dropwizard.metrics:*=4.2.12
+io.grpc:grpc-*=1.50.2
 io.jaegertracing:*=1.8.1
 io.netty:*=4.1.82.Final
+io.opentelemetry:opentelemetry-bom-alpha=1.21.0-alpha

Review Comment:
   What version do we need to get to to NOT use an alpha version?



##########
solr/solr-ref-guide/antora.yml:
##########
@@ -40,16 +40,17 @@ asciidoc:
     # 'patch-version' is the 'z' part of x.y.z semantic version
     page-solr-javadocs: 'https://solr.apache.org/docs/10_0_0'
     solr-javadocs: 'https://solr.apache.org/docs/10_0_0'
-    lucene-javadocs: 'https://lucene.apache.org/core/9_4_0'
+    lucene-javadocs: 'https://lucene.apache.org/core/9_4_2'

Review Comment:
   There is a note about this file not being manually edited:
   
   ```
   # This file is autogenerated by the "setOfficialAntoraYaml" Gradle task, please do not edit manually.
   # Do not run this task outside of the release process on a release branch (branch_9_0, branch_10_2, etc.).
   # Feel free to run the task on unreleased branches (main, branch_9x, branch_10x) to update the dependency versions,
   # but there is usually no need besides more up-to-date nightly builds of the ref-guide.
   ```
   
   was this manually updated or did the task do it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org