You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/01/23 03:33:25 UTC
[PR] [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode [spark]
HyukjinKwon opened a new pull request, #49612:
URL: https://github.com/apache/spark/pull/49612
### What changes were proposed in this pull request?
This PR proposes to rename the internal var `DataFrameWriter.mode` to `DataFrameWriter.curmode`.
### Why are the changes needed?
It's confusing if it refers the method name `mode` or a `var`, `mode` in its parent.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests cases.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #49612:
URL: https://github.com/apache/spark/pull/49612#issuecomment-2608800315
Merged to master and branch-4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #49612:
URL: https://github.com/apache/spark/pull/49612#issuecomment-2611284221
Yup, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #49612:
URL: https://github.com/apache/spark/pull/49612#issuecomment-2609165764
The changes cause a test failure. Please, have a look at the fix: https://github.com/apache/spark/pull/49621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #49612:
URL: https://github.com/apache/spark/pull/49612#issuecomment-2610099227
Hi, @HyukjinKwon and @zhengruifeng .
Since we are close to Spark 4 release phase, please use JIRA ID always for trace-ability next time~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #49612: [MINOR][SQL] Rename the internal var DataFrameWriter.mode to DataFrameWriter.curmode
URL: https://github.com/apache/spark/pull/49612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org