You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2017/08/10 23:59:20 UTC
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
GitHub user orhankislal opened a pull request:
https://github.com/apache/incubator-madlib/pull/165
Release 1.12: Version numbering and upgrade related changes
Updates the version number to 1.12 for the release candidate.
Updates the changelists and other related files for upgrade.
Note that upgrade is not supported from versions prior to 1.9.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/incubator-madlib release/upgrade_1.12
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit fef25344a29a2e7b5a0c8a78baed3abd93e9ec80
Author: Orhan Kislal <ok...@pivotal.io>
Date: 2017-08-10T23:53:36Z
Release 1.12: Version numbering and upgrade related changes
Updates the version number to 1.12 for the release candidate.
Updates the changelists and other related files for upgrade.
Note that upgrade is not supported from versions prior to 1.9.1.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #165: Release 1.12: Version numbering and upgrade rel...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-madlib/pull/165
A couple of things to consider for future releases:
- As much as possible, document this process on the project's wiki (so anyone can pick up the work and not have to rely on so previous PRs or individual team member knowledge).
- Create a JIRA for this work so it will be apparent this work has to be completed before the release. Additionally, this will also allow it to be referenced in the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/165#discussion_r132792193
--- Diff: deploy/gppkg/madlib.spec.in ---
@@ -7,7 +7,7 @@
BuildRoot: @MADLIB_GPPKG_RPM_SOURCE_DIR@
Summary: Apache MADlib for @GPDB_VARIANT@ Database
License: @CPACK_RPM_PACKAGE_LICENSE@
-Name: Apache_MADlib
+Name: madlib
--- End diff --
This change in name created some problems when trying to upgrade from 1.11 to 1.12. It was changed with the 1.11 release and it was not apparent until now. The rpm will be renamed to `apache-madlib-1.12-bin-Linux.rpm` as usual.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/165#discussion_r132792819
--- Diff: deploy/gppkg/madlib.spec.in ---
@@ -7,7 +7,7 @@
BuildRoot: @MADLIB_GPPKG_RPM_SOURCE_DIR@
Summary: Apache MADlib for @GPDB_VARIANT@ Database
License: @CPACK_RPM_PACKAGE_LICENSE@
-Name: Apache_MADlib
+Name: madlib
--- End diff --
The change from `madlib` to `Apache_MADlib` created some problems during upgrade tests so I decided to revert it. The rpm will still be renamed to `apache-madlib-1.12-bin-Linux.rpm`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/165#discussion_r133625244
--- Diff: src/madpack/changelist.yaml ---
@@ -9,27 +9,39 @@
# file installed on the upgrade version. All other files (that don't have
# updates), are cleaned up to remove object replacements
new module:
- # ----------------- Changes from 1.10.0 to 1.11 --------
- pagerank:
+ # ----------------- Changes from 1.11 to 1.12 --------
+ mlp:
+ apsp:
+ bfs:
+ measures:
+ wcc:
+ stratified_sample:
# Changes in the types (UDT) including removal and modification
udt:
-
# List of the UDF changes that affect the user externally. This includes change
# in function name, return type, argument order or types, or removal of
# the function. In each case, the original function is as good as removed and a
# new function is created. In such cases, we should abort the upgrade if there
# are user views dependent on this function, since the original function will
# not be present in the upgraded version.
udf:
- # ----------------- Changes from 1.10.0 to 1.11 ----------
- - __build_tree:
+ # ----------------- Changes from 1.11 to 1.12 ----------
+ - tree_train:
--- End diff --
Are these necessary because of the change in parameter name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/165#discussion_r132790724
--- Diff: deploy/gppkg/madlib.spec.in ---
@@ -7,7 +7,7 @@
BuildRoot: @MADLIB_GPPKG_RPM_SOURCE_DIR@
Summary: Apache MADlib for @GPDB_VARIANT@ Database
License: @CPACK_RPM_PACKAGE_LICENSE@
-Name: Apache_MADlib
+Name: madlib
--- End diff --
This change doesn't appear to version or upgrade related. What is this change for (GPDB specific gppkg spec file)? Aren't we still delivering and rpm named Apache MADlib?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #165: Release 1.12: Version numbering and upgrade rel...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-madlib/pull/165
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/185/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #165: Release 1.12: Version numbering and upgrade rel...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-madlib/pull/165
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/153/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/165#discussion_r133772221
--- Diff: src/madpack/changelist.yaml ---
@@ -9,27 +9,39 @@
# file installed on the upgrade version. All other files (that don't have
# updates), are cleaned up to remove object replacements
new module:
- # ----------------- Changes from 1.10.0 to 1.11 --------
- pagerank:
+ # ----------------- Changes from 1.11 to 1.12 --------
+ mlp:
+ apsp:
+ bfs:
+ measures:
+ wcc:
+ stratified_sample:
# Changes in the types (UDT) including removal and modification
udt:
-
# List of the UDF changes that affect the user externally. This includes change
# in function name, return type, argument order or types, or removal of
# the function. In each case, the original function is as good as removed and a
# new function is created. In such cases, we should abort the upgrade if there
# are user views dependent on this function, since the original function will
# not be present in the upgraded version.
udf:
- # ----------------- Changes from 1.10.0 to 1.11 ----------
- - __build_tree:
+ # ----------------- Changes from 1.11 to 1.12 ----------
+ - tree_train:
--- End diff --
Yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #165: Release 1.12: Version numbering and upgrade rel...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-madlib/pull/165
I believe there is a needed change in (doc/mainpage.dox.in) to add the previous version (v1.11.0) into the "User documentation for earlier releases" section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---