You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Mice Xia <mi...@tcloudcomputing.com> on 2012/07/11 03:38:58 UTC
答复: about patch submit
Hi, Pranav and all
Just one question. As I submit a patch to the reviewboard, should I be better of specifying maintainer according to following link?
http://wiki.cloudstack.org/display/COMM/Draft%3A+CloudStack+Maintainers+Guide
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 12:37
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mike ,
You can perhaps choose "unspecified" as the affect version for the time being and create the bug ticket. The last official version released was 3.0.3 though .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 9:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: about patch submit
Pranav,
Thanks for your detailed reply.
One more thing, if I want to file a bug in http://bugs.cloudstack.org, one of the required fields is 'affect versions', I wonder which one corresponds to branch 3.0.x? is that 3.0.4?
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 10:59
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mice,
To submit a patch , you might want to go through this document once - http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+world
Procedure for submitting a patch through Review Board Tool -
1) Then once you have generated your patch and applied to apache branch(say 3.0.x) , you can go to the review board tool ( https://reviews.apache.org ) to create a new Review request. You'll need to create your account here and then login to your dashboard.
2) To create a new service request , you need to do the following -
2.1) - Click on New Review Request
2.2) - Choose the repository as - cloudstack-git
2.3) - Upload your patch where the "Diff" label is mentioned . You can leave the "Parent Diff" label empty and click on "Create Review Request".
3) Once this is done , you need to choose -
3.1) - Branch - The name of apache branch you are working on ( 3.0.x /Master)
3.2) - Specify the bug ticket number against "Bugs" label
3.3) - Choose groups as "cloustack" which will automatically send an email to cloudstack-dev list for your patch review.
3.4) - Similarly you can specify specific people under the "Peoples" label , in case you want anyone in particular to review your patch.
3.5) - Mention the details under the description , summary , Testing done labels.
4) Finally click on publish to send the patch for review. You'll see an email being sent to the cloudstack group , the specific people you added and yourself.
Let me know in case you have any problems while submitting patches.
Thanks & Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 7:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: about patch submit
Dears,
During trying Cloudstack 3.0.x branch I found some minor bugs, and I would like to submit patches. Can someone tell me the workflow of submitting a patch?
Such as
* Should I file a bug in JIRA?
* Where should I post the patch, in mail list or somewhere else?
* Which branch should I target for?
* Any other things need to pay attention?
Regards
Mice
RE: about patch submit
Posted by Pranav Saxena <pr...@citrix.com>.
You are welcome , Mice . Yeah , you could use the below mentioned link to look up for the module owner .Also you can specify multiple people for your review request , as some module might be under the ownership of more than 1 person.
http://wiki.cloudstack.org/display/COMM/Draft%3A+CloudStack+Maintainers+Guide
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Thursday, July 12, 2012 7:04 AM
To: Pranav Saxena; cloudstack-dev@incubator.apache.org
Subject: 答复: about patch submit
Pranav,
Thanks a lot for your detailed explanation, I will specify reviewers as I submit any patches.
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月11日 10:20
收件人: Mice Xia; cloudstack-dev@incubator.apache.org
主题: RE: about patch submit
Hi Mice,
As I had mentioned previously , that you can specify anyone in particular whom you want to review your patch. The maintainer list mentioned at that link ,will assist you in identifying the person who holds the ownership for their respective modules. So while submitting a patch , if you are specifying any particular person in your review request , it will just speed up the process by sending a mail to that particular person , who in turn can reply you back .Otherwise , it will be delivered to the entire cloudstack group , in which case you might have to wait for someone to review your patch. So, I reckon , it's always a better practice to specify the maintainer .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 11, 2012 7:09 AM
To: Pranav Saxena; cloudstack-dev@incubator.apache.org
Cc: Mice Xia
Subject: 答复: about patch submit
Hi, Pranav and all
Just one question. As I submit a patch to the reviewboard, should I be better of specifying maintainer according to following link?
http://wiki.cloudstack.org/display/COMM/Draft%3A+CloudStack+Maintainers+Guide
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 12:37
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mike ,
You can perhaps choose "unspecified" as the affect version for the time being and create the bug ticket. The last official version released was 3.0.3 though .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 9:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: about patch submit
Pranav,
Thanks for your detailed reply.
One more thing, if I want to file a bug in http://bugs.cloudstack.org, one of the required fields is 'affect versions', I wonder which one corresponds to branch 3.0.x? is that 3.0.4?
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 10:59
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mice,
To submit a patch , you might want to go through this document once - http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+world
Procedure for submitting a patch through Review Board Tool -
1) Then once you have generated your patch and applied to apache branch(say 3.0.x) , you can go to the review board tool ( https://reviews.apache.org ) to create a new Review request. You'll need to create your account here and then login to your dashboard.
2) To create a new service request , you need to do the following -
2.1) - Click on New Review Request
2.2) - Choose the repository as - cloudstack-git
2.3) - Upload your patch where the "Diff" label is mentioned . You can leave the "Parent Diff" label empty and click on "Create Review Request".
3) Once this is done , you need to choose -
3.1) - Branch - The name of apache branch you are working on ( 3.0.x /Master)
3.2) - Specify the bug ticket number against "Bugs" label
3.3) - Choose groups as "cloustack" which will automatically send an email to cloudstack-dev list for your patch review.
3.4) - Similarly you can specify specific people under the "Peoples" label , in case you want anyone in particular to review your patch.
3.5) - Mention the details under the description , summary , Testing done labels.
4) Finally click on publish to send the patch for review. You'll see an email being sent to the cloudstack group , the specific people you added and yourself.
Let me know in case you have any problems while submitting patches.
Thanks & Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 7:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: about patch submit
Dears,
During trying Cloudstack 3.0.x branch I found some minor bugs, and I would like to submit patches. Can someone tell me the workflow of submitting a patch?
Such as
* Should I file a bug in JIRA?
* Where should I post the patch, in mail list or somewhere else?
* Which branch should I target for?
* Any other things need to pay attention?
Regards
Mice
答复: about patch submit
Posted by Mice Xia <mi...@tcloudcomputing.com>.
Pranav,
Thanks a lot for your detailed explanation, I will specify reviewers as I submit any patches.
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月11日 10:20
收件人: Mice Xia; cloudstack-dev@incubator.apache.org
主题: RE: about patch submit
Hi Mice,
As I had mentioned previously , that you can specify anyone in particular whom you want to review your patch. The maintainer list mentioned at that link ,will assist you in identifying the person who holds the ownership for their respective modules. So while submitting a patch , if you are specifying any particular person in your review request , it will just speed up the process by sending a mail to that particular person , who in turn can reply you back .Otherwise , it will be delivered to the entire cloudstack group , in which case you might have to wait for someone to review your patch. So, I reckon , it's always a better practice to specify the maintainer .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 11, 2012 7:09 AM
To: Pranav Saxena; cloudstack-dev@incubator.apache.org
Cc: Mice Xia
Subject: 答复: about patch submit
Hi, Pranav and all
Just one question. As I submit a patch to the reviewboard, should I be better of specifying maintainer according to following link?
http://wiki.cloudstack.org/display/COMM/Draft%3A+CloudStack+Maintainers+Guide
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 12:37
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mike ,
You can perhaps choose "unspecified" as the affect version for the time being and create the bug ticket. The last official version released was 3.0.3 though .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 9:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: about patch submit
Pranav,
Thanks for your detailed reply.
One more thing, if I want to file a bug in http://bugs.cloudstack.org, one of the required fields is 'affect versions', I wonder which one corresponds to branch 3.0.x? is that 3.0.4?
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 10:59
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mice,
To submit a patch , you might want to go through this document once - http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+world
Procedure for submitting a patch through Review Board Tool -
1) Then once you have generated your patch and applied to apache branch(say 3.0.x) , you can go to the review board tool ( https://reviews.apache.org ) to create a new Review request. You'll need to create your account here and then login to your dashboard.
2) To create a new service request , you need to do the following -
2.1) - Click on New Review Request
2.2) - Choose the repository as - cloudstack-git
2.3) - Upload your patch where the "Diff" label is mentioned . You can leave the "Parent Diff" label empty and click on "Create Review Request".
3) Once this is done , you need to choose -
3.1) - Branch - The name of apache branch you are working on ( 3.0.x /Master)
3.2) - Specify the bug ticket number against "Bugs" label
3.3) - Choose groups as "cloustack" which will automatically send an email to cloudstack-dev list for your patch review.
3.4) - Similarly you can specify specific people under the "Peoples" label , in case you want anyone in particular to review your patch.
3.5) - Mention the details under the description , summary , Testing done labels.
4) Finally click on publish to send the patch for review. You'll see an email being sent to the cloudstack group , the specific people you added and yourself.
Let me know in case you have any problems while submitting patches.
Thanks & Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 7:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: about patch submit
Dears,
During trying Cloudstack 3.0.x branch I found some minor bugs, and I would like to submit patches. Can someone tell me the workflow of submitting a patch?
Such as
* Should I file a bug in JIRA?
* Where should I post the patch, in mail list or somewhere else?
* Which branch should I target for?
* Any other things need to pay attention?
Regards
Mice
RE: about patch submit
Posted by Pranav Saxena <pr...@citrix.com>.
Hi Mice,
As I had mentioned previously , that you can specify anyone in particular whom you want to review your patch. The maintainer list mentioned at that link ,will assist you in identifying the person who holds the ownership for their respective modules. So while submitting a patch , if you are specifying any particular person in your review request , it will just speed up the process by sending a mail to that particular person , who in turn can reply you back .Otherwise , it will be delivered to the entire cloudstack group , in which case you might have to wait for someone to review your patch. So, I reckon , it's always a better practice to specify the maintainer .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 11, 2012 7:09 AM
To: Pranav Saxena; cloudstack-dev@incubator.apache.org
Cc: Mice Xia
Subject: 答复: about patch submit
Hi, Pranav and all
Just one question. As I submit a patch to the reviewboard, should I be better of specifying maintainer according to following link?
http://wiki.cloudstack.org/display/COMM/Draft%3A+CloudStack+Maintainers+Guide
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 12:37
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mike ,
You can perhaps choose "unspecified" as the affect version for the time being and create the bug ticket. The last official version released was 3.0.3 though .
Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 9:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: Re: about patch submit
Pranav,
Thanks for your detailed reply.
One more thing, if I want to file a bug in http://bugs.cloudstack.org, one of the required fields is 'affect versions', I wonder which one corresponds to branch 3.0.x? is that 3.0.4?
Regards
Mice
-----邮件原件-----
发件人: Pranav Saxena [mailto:pranav.saxena@citrix.com]
发送时间: 2012年7月4日 10:59
收件人: cloudstack-dev@incubator.apache.org
抄送: Mice Xia
主题: RE: about patch submit
Hi Mice,
To submit a patch , you might want to go through this document once - http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+world
Procedure for submitting a patch through Review Board Tool -
1) Then once you have generated your patch and applied to apache branch(say 3.0.x) , you can go to the review board tool ( https://reviews.apache.org ) to create a new Review request. You'll need to create your account here and then login to your dashboard.
2) To create a new service request , you need to do the following -
2.1) - Click on New Review Request
2.2) - Choose the repository as - cloudstack-git
2.3) - Upload your patch where the "Diff" label is mentioned . You can leave the "Parent Diff" label empty and click on "Create Review Request".
3) Once this is done , you need to choose -
3.1) - Branch - The name of apache branch you are working on ( 3.0.x /Master)
3.2) - Specify the bug ticket number against "Bugs" label
3.3) - Choose groups as "cloustack" which will automatically send an email to cloudstack-dev list for your patch review.
3.4) - Similarly you can specify specific people under the "Peoples" label , in case you want anyone in particular to review your patch.
3.5) - Mention the details under the description , summary , Testing done labels.
4) Finally click on publish to send the patch for review. You'll see an email being sent to the cloudstack group , the specific people you added and yourself.
Let me know in case you have any problems while submitting patches.
Thanks & Regards,
Pranav
-----Original Message-----
From: Mice Xia [mailto:mice_xia@tcloudcomputing.com]
Sent: Wednesday, July 04, 2012 7:55 AM
To: cloudstack-dev@incubator.apache.org
Subject: about patch submit
Dears,
During trying Cloudstack 3.0.x branch I found some minor bugs, and I would like to submit patches. Can someone tell me the workflow of submitting a patch?
Such as
* Should I file a bug in JIRA?
* Where should I post the patch, in mail list or somewhere else?
* Which branch should I target for?
* Any other things need to pay attention?
Regards
Mice