You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/04 02:31:37 UTC
[PR] Enforce preferred Java idioms with Checkstyle [shardingsphere]
terrymanu opened a new pull request, #39721:
URL: https://github.com/apache/shardingsphere/pull/39721
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce preferred Java idioms with Checkstyle [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39721:
URL: https://github.com/apache/shardingsphere/pull/39721#issuecomment-5534835783
### Result
**Review Result: Mergeable**
No actionable findings.
### Evidence
- Full-repository Checkstyle completed successfully with zero violations.
- Spotless completed successfully for all 19 changed Java files.
- All affected modules and their dependencies compiled successfully.
- Focused unit tests passed: 6 tests, 0 failures.
- Searches confirmed no remaining prohibited `Objects` calls, `times(0)`, qualified `PropertiesBuilder.Property` usages, or `Map.Entry` parameters.
- `@SneakyThrows(Exception.class)` was not changed.
### Coverage
- Candidate type: standalone local candidate.
- Baseline: `f46fffd2207a11c9efb71ec20a53df9dd08021ba`.
- Reviewed all 20 task files across correctness, compatibility, maintainability, build configuration, and regression risk.
- CI was not inspected; the conclusion is based on the complete local candidate and local verification.
- The unrelated `UnloadSingleTableExecutorTest.java` change and existing `.codex` cache directories were excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enforce preferred Java idioms with Checkstyle [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39721:
URL: https://github.com/apache/shardingsphere/pull/39721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org