[GitHub] potiuk opened a new pull request #4451: [AIRFLOW-3630] Cleanup of generated connection is done also on exception

[GitBox <gi...@apache.org>]

potiuk opened a new pull request #4451: [AIRFLOW-3630] Cleanup of generated connection is done also on exception
URL: https://github.com/apache/airflow/pull/4451
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-3630
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   When there is an error during Cloud SQL Query, there was a cleanup in post_execute_method. This cleanup is supposed to delete the connection, however it turns out that post_execute is not executed when execute() method throws an error (it was bad assumption). 
   
   The connection is now closed in finally clause in execute.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
      - CloudSqlQueryValidationTest.test_cloudsql_hook_delete_connection_on_exception 
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     No documentation needed.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services