You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:59:47 UTC

[GitHub] [flink] dianfu opened a new pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

dianfu opened a new pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598
 
 
   
   ## What is the purpose of the change
   
   *This pull request adds the support of ArrayType in vectorized Python UDF.*
   
   ## Brief change log
   
     - *Introduces ArrowArrayColumnVector and BaseRowArrayWriter in flink-python module and introduces ColumnarArray and ArrayColumnVector in flink-table-runtime-blink module to support ArrayType in the blink planner for vectorized Python UDF*
     - *Introduces ArrayFieldReader and ArrayWriter in flink-python module to support ArrayType in the old planner for vectorized Python UDF*
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   
     - *Java tests ArrowUtilsTest, RowArrowReaderWriterTest and BaseRowArrowReaderWriterTest*
     - *Python tests: test_pandas_udf.test_all_data_types*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402746198
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/ColumnarArray.java
 ##########
 @@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.dataformat;
+
+import org.apache.flink.table.dataformat.vector.ArrayColumnVector;
+import org.apache.flink.table.dataformat.vector.BooleanColumnVector;
+import org.apache.flink.table.dataformat.vector.ByteColumnVector;
+import org.apache.flink.table.dataformat.vector.BytesColumnVector;
+import org.apache.flink.table.dataformat.vector.ColumnVector;
+import org.apache.flink.table.dataformat.vector.DecimalColumnVector;
+import org.apache.flink.table.dataformat.vector.DoubleColumnVector;
+import org.apache.flink.table.dataformat.vector.FloatColumnVector;
+import org.apache.flink.table.dataformat.vector.IntColumnVector;
+import org.apache.flink.table.dataformat.vector.LongColumnVector;
+import org.apache.flink.table.dataformat.vector.ShortColumnVector;
+import org.apache.flink.table.dataformat.vector.TimestampColumnVector;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TinyIntType;
+
+/**
+ * Columnar array to support access to vector column data.
+ */
+public final class ColumnarArray implements BaseArray {
+
+	private final DataType elementType;
+	private final ColumnVector data;
+	private final int offset;
+	private final int length;
+
+	public ColumnarArray(DataType elementType, ColumnVector data, int offset, int length) {
+		this.elementType = elementType;
+		this.data = data;
+		this.offset = offset;
+		this.length = length;
+	}
+
+	@Override
+	public int numElements() {
+		return length;
+	}
+
+	@Override
+	public boolean isNullAt(int pos) {
+		return data.isNullAt(offset + pos);
+	}
+
+	@Override
+	public void setNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean getBoolean(int ordinal) {
+		return ((BooleanColumnVector) data).getBoolean(offset + ordinal);
+	}
+
+	@Override
+	public byte getByte(int ordinal) {
+		return ((ByteColumnVector) data).getByte(offset + ordinal);
+	}
+
+	@Override
+	public short getShort(int ordinal) {
+		return ((ShortColumnVector) data).getShort(offset + ordinal);
+	}
+
+	@Override
+	public int getInt(int ordinal) {
+		return ((IntColumnVector) data).getInt(offset + ordinal);
+	}
+
+	@Override
+	public long getLong(int ordinal) {
+		return ((LongColumnVector) data).getLong(offset + ordinal);
+	}
+
+	@Override
+	public float getFloat(int ordinal) {
+		return ((FloatColumnVector) data).getFloat(offset + ordinal);
+	}
+
+	@Override
+	public double getDouble(int ordinal) {
+		return ((DoubleColumnVector) data).getDouble(offset + ordinal);
+	}
+
+	@Override
+	public BinaryString getString(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		return BinaryString.fromBytes(byteArray.data, byteArray.offset, byteArray.len);
+	}
+
+	@Override
+	public Decimal getDecimal(int ordinal, int precision, int scale) {
+		return ((DecimalColumnVector) data).getDecimal(offset + ordinal, precision, scale);
+	}
+
+	@Override
+	public SqlTimestamp getTimestamp(int ordinal, int precision) {
+		return ((TimestampColumnVector) data).getTimestamp(offset + ordinal, precision);
+	}
+
+	@Override
+	public <T> BinaryGeneric<T> getGeneric(int ordinal) {
+		throw new UnsupportedOperationException("GenericType is not supported.");
+	}
+
+	@Override
+	public byte[] getBinary(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		if (byteArray.len == byteArray.data.length) {
+			return byteArray.data;
+		} else {
+			byte[] ret = new byte[byteArray.len];
+			System.arraycopy(byteArray.data, byteArray.offset, ret, 0, byteArray.len);
+			return ret;
+		}
+	}
+
+	@Override
+	public BaseArray getArray(int ordinal) {
+		return ((ArrayColumnVector) data).getArray(offset + ordinal);
+	}
+
+	@Override
+	public BaseMap getMap(int ordinal) {
+		throw new UnsupportedOperationException("Map is not supported.");
+	}
+
+	@Override
+	public BaseRow getRow(int ordinal, int numFields) {
+		throw new UnsupportedOperationException("Row is not supported.");
+	}
+
+	@Override
+	public void setBoolean(int ordinal, boolean value) {
 
 Review comment:
   These annoyed "set" will be removed after FLIP-95.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 18822435d028d86859d2b2becbb4e63ae2843f1c Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/157700295) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963) 
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719701) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157474444) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929) 
   * 18822435d028d86859d2b2becbb4e63ae2843f1c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157700295) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-610191068
 
 
   @JingsongLi @dianfu Thanks a lot for the review and update. I will take a quick look at the PR before merging this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-608295450
 
 
   @JingsongLi Thanks for the review. Most points make sense to me and have updated the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74dc1907b38d2336682cc4e5833a78e436871714 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158368639) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065) 
   * 2fd5c0d6bab68aaf5f8642afa63773a61191524d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158916586",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7131",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74dc1907b38d2336682cc4e5833a78e436871714 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158368639) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065) 
   * 2fd5c0d6bab68aaf5f8642afa63773a61191524d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158916586) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7131) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402746022
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/ColumnarArray.java
 ##########
 @@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.dataformat;
+
+import org.apache.flink.table.dataformat.vector.ArrayColumnVector;
+import org.apache.flink.table.dataformat.vector.BooleanColumnVector;
+import org.apache.flink.table.dataformat.vector.ByteColumnVector;
+import org.apache.flink.table.dataformat.vector.BytesColumnVector;
+import org.apache.flink.table.dataformat.vector.ColumnVector;
+import org.apache.flink.table.dataformat.vector.DecimalColumnVector;
+import org.apache.flink.table.dataformat.vector.DoubleColumnVector;
+import org.apache.flink.table.dataformat.vector.FloatColumnVector;
+import org.apache.flink.table.dataformat.vector.IntColumnVector;
+import org.apache.flink.table.dataformat.vector.LongColumnVector;
+import org.apache.flink.table.dataformat.vector.ShortColumnVector;
+import org.apache.flink.table.dataformat.vector.TimestampColumnVector;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TinyIntType;
+
+/**
+ * Columnar array to support access to vector column data.
+ */
+public final class ColumnarArray implements BaseArray {
+
+	private final DataType elementType;
+	private final ColumnVector data;
+	private final int offset;
+	private final int length;
+
+	public ColumnarArray(DataType elementType, ColumnVector data, int offset, int length) {
+		this.elementType = elementType;
+		this.data = data;
+		this.offset = offset;
+		this.length = length;
+	}
+
+	@Override
+	public int numElements() {
+		return length;
+	}
+
+	@Override
+	public boolean isNullAt(int pos) {
+		return data.isNullAt(offset + pos);
+	}
+
+	@Override
+	public void setNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean getBoolean(int ordinal) {
+		return ((BooleanColumnVector) data).getBoolean(offset + ordinal);
+	}
+
+	@Override
+	public byte getByte(int ordinal) {
+		return ((ByteColumnVector) data).getByte(offset + ordinal);
+	}
+
+	@Override
+	public short getShort(int ordinal) {
+		return ((ShortColumnVector) data).getShort(offset + ordinal);
+	}
+
+	@Override
+	public int getInt(int ordinal) {
+		return ((IntColumnVector) data).getInt(offset + ordinal);
+	}
+
+	@Override
+	public long getLong(int ordinal) {
+		return ((LongColumnVector) data).getLong(offset + ordinal);
+	}
+
+	@Override
+	public float getFloat(int ordinal) {
+		return ((FloatColumnVector) data).getFloat(offset + ordinal);
+	}
+
+	@Override
+	public double getDouble(int ordinal) {
+		return ((DoubleColumnVector) data).getDouble(offset + ordinal);
+	}
+
+	@Override
+	public BinaryString getString(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		return BinaryString.fromBytes(byteArray.data, byteArray.offset, byteArray.len);
+	}
+
+	@Override
+	public Decimal getDecimal(int ordinal, int precision, int scale) {
+		return ((DecimalColumnVector) data).getDecimal(offset + ordinal, precision, scale);
+	}
+
+	@Override
+	public SqlTimestamp getTimestamp(int ordinal, int precision) {
+		return ((TimestampColumnVector) data).getTimestamp(offset + ordinal, precision);
+	}
+
+	@Override
+	public <T> BinaryGeneric<T> getGeneric(int ordinal) {
+		throw new UnsupportedOperationException("GenericType is not supported.");
+	}
+
+	@Override
+	public byte[] getBinary(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		if (byteArray.len == byteArray.data.length) {
+			return byteArray.data;
+		} else {
+			byte[] ret = new byte[byteArray.len];
+			System.arraycopy(byteArray.data, byteArray.offset, ret, 0, byteArray.len);
+			return ret;
+		}
+	}
+
+	@Override
+	public BaseArray getArray(int ordinal) {
+		return ((ArrayColumnVector) data).getArray(offset + ordinal);
+	}
+
+	@Override
+	public BaseMap getMap(int ordinal) {
+		throw new UnsupportedOperationException("Map is not supported.");
+	}
+
+	@Override
+	public BaseRow getRow(int ordinal, int numFields) {
+		throw new UnsupportedOperationException("Row is not supported.");
+	}
+
+	@Override
+	public void setBoolean(int ordinal, boolean value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setByte(int ordinal, byte value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setShort(int ordinal, short value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setInt(int ordinal, int value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setLong(int ordinal, long value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setFloat(int ordinal, float value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setDouble(int ordinal, double value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setDecimal(int i, Decimal value, int precision) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setTimestamp(int ordinal, SqlTimestamp value, int precision) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNotNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullLong(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullInt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullBoolean(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullByte(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullShort(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullFloat(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullDouble(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean[] toBooleanArray() {
+		boolean[] res = new boolean[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getBoolean(i);
+		}
+		return res;
+	}
+
+	@Override
+	public byte[] toByteArray() {
+		byte[] res = new byte[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getByte(i);
+		}
+		return res;
+	}
+
+	@Override
+	public short[] toShortArray() {
+		short[] res = new short[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getShort(i);
+		}
+		return res;
+	}
+
+	@Override
+	public int[] toIntArray() {
+		int[] res = new int[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getInt(i);
+		}
+		return res;
+	}
+
+	@Override
+	public long[] toLongArray() {
+		long[] res = new long[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getLong(i);
+		}
+		return res;
+	}
+
+	@Override
+	public float[] toFloatArray() {
+		float[] res = new float[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getFloat(i);
+		}
+		return res;
+	}
+
+	@Override
+	public double[] toDoubleArray() {
+		double[] res = new double[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getDouble(i);
+		}
+		return res;
+	}
+
+	public BaseArray copy() {
 
 Review comment:
   Can we move this method to serializer or somewhere?
   So we don't need this elementType field.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402746856
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/ColumnarArray.java
 ##########
 @@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.dataformat;
+
+import org.apache.flink.table.dataformat.vector.ArrayColumnVector;
+import org.apache.flink.table.dataformat.vector.BooleanColumnVector;
+import org.apache.flink.table.dataformat.vector.ByteColumnVector;
+import org.apache.flink.table.dataformat.vector.BytesColumnVector;
+import org.apache.flink.table.dataformat.vector.ColumnVector;
+import org.apache.flink.table.dataformat.vector.DecimalColumnVector;
+import org.apache.flink.table.dataformat.vector.DoubleColumnVector;
+import org.apache.flink.table.dataformat.vector.FloatColumnVector;
+import org.apache.flink.table.dataformat.vector.IntColumnVector;
+import org.apache.flink.table.dataformat.vector.LongColumnVector;
+import org.apache.flink.table.dataformat.vector.ShortColumnVector;
+import org.apache.flink.table.dataformat.vector.TimestampColumnVector;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TinyIntType;
+
+/**
+ * Columnar array to support access to vector column data.
+ */
+public final class ColumnarArray implements BaseArray {
+
+	private final DataType elementType;
+	private final ColumnVector data;
+	private final int offset;
+	private final int length;
+
+	public ColumnarArray(DataType elementType, ColumnVector data, int offset, int length) {
+		this.elementType = elementType;
+		this.data = data;
+		this.offset = offset;
+		this.length = length;
+	}
+
+	@Override
+	public int numElements() {
+		return length;
+	}
+
+	@Override
+	public boolean isNullAt(int pos) {
+		return data.isNullAt(offset + pos);
+	}
+
+	@Override
+	public void setNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean getBoolean(int ordinal) {
+		return ((BooleanColumnVector) data).getBoolean(offset + ordinal);
+	}
+
+	@Override
+	public byte getByte(int ordinal) {
+		return ((ByteColumnVector) data).getByte(offset + ordinal);
+	}
+
+	@Override
+	public short getShort(int ordinal) {
+		return ((ShortColumnVector) data).getShort(offset + ordinal);
+	}
+
+	@Override
+	public int getInt(int ordinal) {
+		return ((IntColumnVector) data).getInt(offset + ordinal);
+	}
+
+	@Override
+	public long getLong(int ordinal) {
+		return ((LongColumnVector) data).getLong(offset + ordinal);
+	}
+
+	@Override
+	public float getFloat(int ordinal) {
+		return ((FloatColumnVector) data).getFloat(offset + ordinal);
+	}
+
+	@Override
+	public double getDouble(int ordinal) {
+		return ((DoubleColumnVector) data).getDouble(offset + ordinal);
+	}
+
+	@Override
+	public BinaryString getString(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		return BinaryString.fromBytes(byteArray.data, byteArray.offset, byteArray.len);
+	}
+
+	@Override
+	public Decimal getDecimal(int ordinal, int precision, int scale) {
+		return ((DecimalColumnVector) data).getDecimal(offset + ordinal, precision, scale);
+	}
+
+	@Override
+	public SqlTimestamp getTimestamp(int ordinal, int precision) {
+		return ((TimestampColumnVector) data).getTimestamp(offset + ordinal, precision);
+	}
+
+	@Override
+	public <T> BinaryGeneric<T> getGeneric(int ordinal) {
+		throw new UnsupportedOperationException("GenericType is not supported.");
+	}
+
+	@Override
+	public byte[] getBinary(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		if (byteArray.len == byteArray.data.length) {
+			return byteArray.data;
+		} else {
+			byte[] ret = new byte[byteArray.len];
+			System.arraycopy(byteArray.data, byteArray.offset, ret, 0, byteArray.len);
 
 Review comment:
   Can we use `Arrays.copyOfRange`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 63413908d1cb09badbd6c9492817d665dad7279e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158334497) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402044488
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/arrow/writers/BaseRowIntWriter.java
 ##########
 @@ -19,22 +19,22 @@
 package org.apache.flink.table.runtime.arrow.writers;
 
 import org.apache.flink.annotation.Internal;
-import org.apache.flink.table.dataformat.BaseRow;
+import org.apache.flink.table.dataformat.TypeGetterSetters;
 
 import org.apache.arrow.vector.IntVector;
 
 /**
  * {@link ArrowFieldWriter} for Int.
  */
 @Internal
-public final class BaseRowIntWriter extends ArrowFieldWriter<BaseRow> {
+public final class BaseRowIntWriter<T extends TypeGetterSetters> extends ArrowFieldWriter<T> {
 
 Review comment:
   If we going to support generic type that extends TypeGetterSetters, the class name `BaseRowIntWriter` may not be appropriate now. It may not be a BaseRow but can also be a BaseArray. 
   
   Same for other BaseRowXXXWriter classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607708507
 
 
   @hequn8128 Good catch. Updated the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402095415
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/arrow/ArrowUtils.java
 ##########
 @@ -223,39 +239,43 @@ private static Field toArrowField(RowType.RowField rowField) {
 
 	private static ArrowFieldWriter<BaseRow> createBaseRowArrowFieldWriter(FieldVector vector, LogicalType fieldType) {
 
 Review comment:
   The return type now may not be a BaseRow. Maybe also add a test in `BaseRowArrowReaderWriterTest` to cover this case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719701) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971) 
   * deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158159128) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 63413908d1cb09badbd6c9492817d665dad7279e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158334497) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055) 
   * 74dc1907b38d2336682cc4e5833a78e436871714 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158368639) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607640648
 
 
   @hequn8128  Thanks a lot for the review. The comments make sense to me and have updated the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402760160
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/ColumnarArray.java
 ##########
 @@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.dataformat;
+
+import org.apache.flink.table.dataformat.vector.ArrayColumnVector;
+import org.apache.flink.table.dataformat.vector.BooleanColumnVector;
+import org.apache.flink.table.dataformat.vector.ByteColumnVector;
+import org.apache.flink.table.dataformat.vector.BytesColumnVector;
+import org.apache.flink.table.dataformat.vector.ColumnVector;
+import org.apache.flink.table.dataformat.vector.DecimalColumnVector;
+import org.apache.flink.table.dataformat.vector.DoubleColumnVector;
+import org.apache.flink.table.dataformat.vector.FloatColumnVector;
+import org.apache.flink.table.dataformat.vector.IntColumnVector;
+import org.apache.flink.table.dataformat.vector.LongColumnVector;
+import org.apache.flink.table.dataformat.vector.ShortColumnVector;
+import org.apache.flink.table.dataformat.vector.TimestampColumnVector;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TinyIntType;
+
+/**
+ * Columnar array to support access to vector column data.
+ */
+public final class ColumnarArray implements BaseArray {
+
+	private final DataType elementType;
+	private final ColumnVector data;
+	private final int offset;
+	private final int length;
+
+	public ColumnarArray(DataType elementType, ColumnVector data, int offset, int length) {
+		this.elementType = elementType;
+		this.data = data;
+		this.offset = offset;
+		this.length = length;
+	}
+
+	@Override
+	public int numElements() {
+		return length;
+	}
+
+	@Override
+	public boolean isNullAt(int pos) {
+		return data.isNullAt(offset + pos);
+	}
+
+	@Override
+	public void setNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean getBoolean(int ordinal) {
+		return ((BooleanColumnVector) data).getBoolean(offset + ordinal);
+	}
+
+	@Override
+	public byte getByte(int ordinal) {
+		return ((ByteColumnVector) data).getByte(offset + ordinal);
+	}
+
+	@Override
+	public short getShort(int ordinal) {
+		return ((ShortColumnVector) data).getShort(offset + ordinal);
+	}
+
+	@Override
+	public int getInt(int ordinal) {
+		return ((IntColumnVector) data).getInt(offset + ordinal);
+	}
+
+	@Override
+	public long getLong(int ordinal) {
+		return ((LongColumnVector) data).getLong(offset + ordinal);
+	}
+
+	@Override
+	public float getFloat(int ordinal) {
+		return ((FloatColumnVector) data).getFloat(offset + ordinal);
+	}
+
+	@Override
+	public double getDouble(int ordinal) {
+		return ((DoubleColumnVector) data).getDouble(offset + ordinal);
+	}
+
+	@Override
+	public BinaryString getString(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		return BinaryString.fromBytes(byteArray.data, byteArray.offset, byteArray.len);
+	}
+
+	@Override
+	public Decimal getDecimal(int ordinal, int precision, int scale) {
+		return ((DecimalColumnVector) data).getDecimal(offset + ordinal, precision, scale);
+	}
+
+	@Override
+	public SqlTimestamp getTimestamp(int ordinal, int precision) {
+		return ((TimestampColumnVector) data).getTimestamp(offset + ordinal, precision);
+	}
+
+	@Override
+	public <T> BinaryGeneric<T> getGeneric(int ordinal) {
+		throw new UnsupportedOperationException("GenericType is not supported.");
+	}
+
+	@Override
+	public byte[] getBinary(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		if (byteArray.len == byteArray.data.length) {
+			return byteArray.data;
+		} else {
+			byte[] ret = new byte[byteArray.len];
+			System.arraycopy(byteArray.data, byteArray.offset, ret, 0, byteArray.len);
+			return ret;
+		}
+	}
+
+	@Override
+	public BaseArray getArray(int ordinal) {
+		return ((ArrayColumnVector) data).getArray(offset + ordinal);
+	}
+
+	@Override
+	public BaseMap getMap(int ordinal) {
+		throw new UnsupportedOperationException("Map is not supported.");
+	}
+
+	@Override
+	public BaseRow getRow(int ordinal, int numFields) {
+		throw new UnsupportedOperationException("Row is not supported.");
+	}
+
+	@Override
+	public void setBoolean(int ordinal, boolean value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setByte(int ordinal, byte value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setShort(int ordinal, short value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setInt(int ordinal, int value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setLong(int ordinal, long value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setFloat(int ordinal, float value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setDouble(int ordinal, double value) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setDecimal(int i, Decimal value, int precision) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setTimestamp(int ordinal, SqlTimestamp value, int precision) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNotNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullLong(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullInt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullBoolean(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullByte(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullShort(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullFloat(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public void setNullDouble(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean[] toBooleanArray() {
+		boolean[] res = new boolean[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getBoolean(i);
+		}
+		return res;
+	}
+
+	@Override
+	public byte[] toByteArray() {
+		byte[] res = new byte[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getByte(i);
+		}
+		return res;
+	}
+
+	@Override
+	public short[] toShortArray() {
+		short[] res = new short[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getShort(i);
+		}
+		return res;
+	}
+
+	@Override
+	public int[] toIntArray() {
+		int[] res = new int[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getInt(i);
+		}
+		return res;
+	}
+
+	@Override
+	public long[] toLongArray() {
+		long[] res = new long[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getLong(i);
+		}
+		return res;
+	}
+
+	@Override
+	public float[] toFloatArray() {
+		float[] res = new float[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getFloat(i);
+		}
+		return res;
+	}
+
+	@Override
+	public double[] toDoubleArray() {
+		double[] res = new double[length];
+		for (int i = 0; i < length; i++) {
+			res[i] = getDouble(i);
+		}
+		return res;
+	}
+
+	public BaseArray copy() {
+		LogicalType elementLogicalType = elementType.getLogicalType();
+		if (elementLogicalType instanceof BooleanType) {
+			return BinaryArray.fromPrimitiveArray(toBooleanArray());
+		} else if (elementLogicalType instanceof TinyIntType) {
+			return BinaryArray.fromPrimitiveArray(toByteArray());
+		} else if (elementLogicalType instanceof SmallIntType) {
+			return BinaryArray.fromPrimitiveArray(toShortArray());
+		} else if (elementLogicalType instanceof IntType || elementLogicalType instanceof DateType || elementLogicalType instanceof TimeType) {
+			return BinaryArray.fromPrimitiveArray(toIntArray());
+		} else if (elementLogicalType instanceof BigIntType) {
+			return BinaryArray.fromPrimitiveArray(toLongArray());
+		} else if (elementLogicalType instanceof FloatType) {
+			return BinaryArray.fromPrimitiveArray(toFloatArray());
+		} else if (elementLogicalType instanceof DoubleType) {
+			return BinaryArray.fromPrimitiveArray(toDoubleArray());
+		} else {
+			DataFormatConverters.ObjectArrayConverter converter = new DataFormatConverters.ObjectArrayConverter(elementType);
 
 Review comment:
   I can not get this. What we want is copy instead of conversion between external and internal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157474444) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 merged pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r404523077
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BaseArraySerializer.java
 ##########
 @@ -134,6 +139,48 @@ private GenericArray copyGenericArray(GenericArray array) {
 		return new GenericArray(arr, array.numElements(), array.isPrimitiveArray());
 	}
 
+	private GenericArray copyColumnarArray(ColumnarArray from) {
+		Object arr;
+		boolean isPrimitiveArray = true;
+		switch (eleType.getTypeRoot()) {
+			case BOOLEAN:
+				arr = from.toBooleanArray();
 
 Review comment:
   Good catch. We should check the nullable. Updated the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 63413908d1cb09badbd6c9492817d665dad7279e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158334497) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055) 
   * 74dc1907b38d2336682cc4e5833a78e436871714 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402148273
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/arrow/ArrowUtils.java
 ##########
 @@ -223,39 +239,43 @@ private static Field toArrowField(RowType.RowField rowField) {
 
 	private static ArrowFieldWriter<BaseRow> createBaseRowArrowFieldWriter(FieldVector vector, LogicalType fieldType) {
 
 Review comment:
   Good catch! Updated the result type. However, have not added a new test as this is already covered in the BaseRowArrowReaderWriterTest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158159128) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027) 
   * 63413908d1cb09badbd6c9492817d665dad7279e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 18822435d028d86859d2b2becbb4e63ae2843f1c Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/157700295) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963) 
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157719701) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157474444) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r404509998
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BaseArraySerializer.java
 ##########
 @@ -134,6 +139,48 @@ private GenericArray copyGenericArray(GenericArray array) {
 		return new GenericArray(arr, array.numElements(), array.isPrimitiveArray());
 	}
 
+	private GenericArray copyColumnarArray(ColumnarArray from) {
+		Object arr;
+		boolean isPrimitiveArray = true;
+		switch (eleType.getTypeRoot()) {
+			case BOOLEAN:
+				arr = from.toBooleanArray();
 
 Review comment:
   We can invoke toPrimitiveArray only then nullable is false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74dc1907b38d2336682cc4e5833a78e436871714 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158368639) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607156947
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 (Wed Apr 01 10:03:19 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402765167
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/ColumnarArray.java
 ##########
 @@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.dataformat;
+
+import org.apache.flink.table.dataformat.vector.ArrayColumnVector;
+import org.apache.flink.table.dataformat.vector.BooleanColumnVector;
+import org.apache.flink.table.dataformat.vector.ByteColumnVector;
+import org.apache.flink.table.dataformat.vector.BytesColumnVector;
+import org.apache.flink.table.dataformat.vector.ColumnVector;
+import org.apache.flink.table.dataformat.vector.DecimalColumnVector;
+import org.apache.flink.table.dataformat.vector.DoubleColumnVector;
+import org.apache.flink.table.dataformat.vector.FloatColumnVector;
+import org.apache.flink.table.dataformat.vector.IntColumnVector;
+import org.apache.flink.table.dataformat.vector.LongColumnVector;
+import org.apache.flink.table.dataformat.vector.ShortColumnVector;
+import org.apache.flink.table.dataformat.vector.TimestampColumnVector;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TinyIntType;
+
+/**
+ * Columnar array to support access to vector column data.
+ */
+public final class ColumnarArray implements BaseArray {
+
+	private final DataType elementType;
+	private final ColumnVector data;
+	private final int offset;
+	private final int length;
+
+	public ColumnarArray(DataType elementType, ColumnVector data, int offset, int length) {
+		this.elementType = elementType;
+		this.data = data;
+		this.offset = offset;
+		this.length = length;
+	}
+
+	@Override
+	public int numElements() {
+		return length;
+	}
+
+	@Override
+	public boolean isNullAt(int pos) {
+		return data.isNullAt(offset + pos);
+	}
+
+	@Override
+	public void setNullAt(int pos) {
+		throw new UnsupportedOperationException("Not support the operation!");
+	}
+
+	@Override
+	public boolean getBoolean(int ordinal) {
+		return ((BooleanColumnVector) data).getBoolean(offset + ordinal);
+	}
+
+	@Override
+	public byte getByte(int ordinal) {
+		return ((ByteColumnVector) data).getByte(offset + ordinal);
+	}
+
+	@Override
+	public short getShort(int ordinal) {
+		return ((ShortColumnVector) data).getShort(offset + ordinal);
+	}
+
+	@Override
+	public int getInt(int ordinal) {
+		return ((IntColumnVector) data).getInt(offset + ordinal);
+	}
+
+	@Override
+	public long getLong(int ordinal) {
+		return ((LongColumnVector) data).getLong(offset + ordinal);
+	}
+
+	@Override
+	public float getFloat(int ordinal) {
+		return ((FloatColumnVector) data).getFloat(offset + ordinal);
+	}
+
+	@Override
+	public double getDouble(int ordinal) {
+		return ((DoubleColumnVector) data).getDouble(offset + ordinal);
+	}
+
+	@Override
+	public BinaryString getString(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		return BinaryString.fromBytes(byteArray.data, byteArray.offset, byteArray.len);
+	}
+
+	@Override
+	public Decimal getDecimal(int ordinal, int precision, int scale) {
+		return ((DecimalColumnVector) data).getDecimal(offset + ordinal, precision, scale);
+	}
+
+	@Override
+	public SqlTimestamp getTimestamp(int ordinal, int precision) {
+		return ((TimestampColumnVector) data).getTimestamp(offset + ordinal, precision);
+	}
+
+	@Override
+	public <T> BinaryGeneric<T> getGeneric(int ordinal) {
+		throw new UnsupportedOperationException("GenericType is not supported.");
+	}
+
+	@Override
+	public byte[] getBinary(int ordinal) {
+		BytesColumnVector.Bytes byteArray = getByteArray(ordinal);
+		if (byteArray.len == byteArray.data.length) {
+			return byteArray.data;
+		} else {
+			byte[] ret = new byte[byteArray.len];
+			System.arraycopy(byteArray.data, byteArray.offset, ret, 0, byteArray.len);
+			return ret;
+		}
+	}
+
+	@Override
+	public BaseArray getArray(int ordinal) {
+		return ((ArrayColumnVector) data).getArray(offset + ordinal);
+	}
+
+	@Override
+	public BaseMap getMap(int ordinal) {
+		throw new UnsupportedOperationException("Map is not supported.");
+	}
+
+	@Override
+	public BaseRow getRow(int ordinal, int numFields) {
+		throw new UnsupportedOperationException("Row is not supported.");
+	}
+
+	@Override
+	public void setBoolean(int ordinal, boolean value) {
 
 Review comment:
   Thanks for letting me know. As this is still needed for now and so just keep it in this PR and we can remove it during FLIP-95.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157474444) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929) 
   * 18822435d028d86859d2b2becbb4e63ae2843f1c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157700295) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963) 
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719701) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971) 
   * deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157474444) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157474444) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929) 
   * 18822435d028d86859d2b2becbb4e63ae2843f1c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158916586",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7131",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2fd5c0d6bab68aaf5f8642afa63773a61191524d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158916586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7131) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 63413908d1cb09badbd6c9492817d665dad7279e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158334497) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719701) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402069877
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/arrow/writers/BaseRowIntWriter.java
 ##########
 @@ -19,22 +19,22 @@
 package org.apache.flink.table.runtime.arrow.writers;
 
 import org.apache.flink.annotation.Internal;
-import org.apache.flink.table.dataformat.BaseRow;
+import org.apache.flink.table.dataformat.TypeGetterSetters;
 
 import org.apache.arrow.vector.IntVector;
 
 /**
  * {@link ArrowFieldWriter} for Int.
  */
 @Internal
-public final class BaseRowIntWriter extends ArrowFieldWriter<BaseRow> {
+public final class BaseRowIntWriter<T extends TypeGetterSetters> extends ArrowFieldWriter<T> {
 
 Review comment:
   Make sense to me. Have renamed the original IntWriter to RowIntWriter and BaseRowIntWriter to IntWriter. Also updated the other classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6849f6c616060c7ecb85f65a9a915b6b3182710d Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157719701) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74dc1907b38d2336682cc4e5833a78e436871714 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158368639) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158159128) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7065",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158368639",
       "triggerID" : "74dc1907b38d2336682cc4e5833a78e436871714",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158916586",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7131",
       "triggerID" : "2fd5c0d6bab68aaf5f8642afa63773a61191524d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2fd5c0d6bab68aaf5f8642afa63773a61191524d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158916586) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7131) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402747024
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/ColumnarArray.java
 ##########
 @@ -0,0 +1,332 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.dataformat;
+
+import org.apache.flink.table.dataformat.vector.ArrayColumnVector;
+import org.apache.flink.table.dataformat.vector.BooleanColumnVector;
+import org.apache.flink.table.dataformat.vector.ByteColumnVector;
+import org.apache.flink.table.dataformat.vector.BytesColumnVector;
+import org.apache.flink.table.dataformat.vector.ColumnVector;
+import org.apache.flink.table.dataformat.vector.DecimalColumnVector;
+import org.apache.flink.table.dataformat.vector.DoubleColumnVector;
+import org.apache.flink.table.dataformat.vector.FloatColumnVector;
+import org.apache.flink.table.dataformat.vector.IntColumnVector;
+import org.apache.flink.table.dataformat.vector.LongColumnVector;
+import org.apache.flink.table.dataformat.vector.ShortColumnVector;
+import org.apache.flink.table.dataformat.vector.TimestampColumnVector;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.BooleanType;
+import org.apache.flink.table.types.logical.DateType;
+import org.apache.flink.table.types.logical.DoubleType;
+import org.apache.flink.table.types.logical.FloatType;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.SmallIntType;
+import org.apache.flink.table.types.logical.TimeType;
+import org.apache.flink.table.types.logical.TinyIntType;
+
+/**
+ * Columnar array to support access to vector column data.
+ */
+public final class ColumnarArray implements BaseArray {
+
+	private final DataType elementType;
+	private final ColumnVector data;
+	private final int offset;
+	private final int length;
+
+	public ColumnarArray(DataType elementType, ColumnVector data, int offset, int length) {
+		this.elementType = elementType;
+		this.data = data;
+		this.offset = offset;
+		this.length = length;
 
 Review comment:
   length -> numElements?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158334497",
       "triggerID" : "63413908d1cb09badbd6c9492817d665dad7279e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158159128) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027) 
   * 63413908d1cb09badbd6c9492817d665dad7279e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158334497) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7055) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#issuecomment-607168470
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6929",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157474444",
       "triggerID" : "d81b0e98dc23cf9370cdfdd20b39dd8cfdab3f84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157700295",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6963",
       "triggerID" : "18822435d028d86859d2b2becbb4e63ae2843f1c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157719701",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6971",
       "triggerID" : "6849f6c616060c7ecb85f65a9a915b6b3182710d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     }, {
       "hash" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158159128",
       "triggerID" : "deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * deb7f3ddd8feaf154dacac8f5f8a46b6b34807bd Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158159128) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7027) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402041197
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_pandas_udf.py
 ##########
 @@ -207,20 +213,38 @@ def timestamp_func(timestamp_param):
             udf(timestamp_func, [DataTypes.TIMESTAMP(3)], DataTypes.TIMESTAMP(3),
                 udf_type="pandas"))
 
+        self.t_env.register_function(
+            "array_str_func",
+            udf(array_func, [DataTypes.ARRAY(DataTypes.STRING())],
+                DataTypes.ARRAY(DataTypes.STRING()), udf_type="pandas"))
+
+        self.t_env.register_function(
+            "array_timestamp_func",
+            udf(array_func, [DataTypes.ARRAY(DataTypes.TIMESTAMP(3))],
+                DataTypes.ARRAY(DataTypes.TIMESTAMP(3)), udf_type="pandas"))
+
+        self.t_env.register_function(
+            "array_int_func",
+            udf(array_func, [DataTypes.ARRAY(DataTypes.INT())],
+                DataTypes.ARRAY(DataTypes.INT()), udf_type="pandas"))
+
         table_sink = source_sink_utils.TestAppendSink(
-            ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p'],
+            ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q',
+             'r', 's'],
             [DataTypes.TINYINT(), DataTypes.SMALLINT(), DataTypes.INT(), DataTypes.BIGINT(),
              DataTypes.BOOLEAN(), DataTypes.BOOLEAN(), DataTypes.FLOAT(), DataTypes.DOUBLE(),
              DataTypes.STRING(), DataTypes.STRING(), DataTypes.BYTES(), DataTypes.DECIMAL(38, 18),
-             DataTypes.DECIMAL(38, 18), DataTypes.DATE(), DataTypes.TIME(), DataTypes.TIMESTAMP(3)])
+             DataTypes.DECIMAL(38, 18), DataTypes.DATE(), DataTypes.TIME(), DataTypes.TIMESTAMP(3),
+             DataTypes.ARRAY(DataTypes.STRING()), DataTypes.ARRAY(DataTypes.TIMESTAMP(3)),
+             DataTypes.ARRAY(DataTypes.INT())])
         self.t_env.register_table_sink("Results", table_sink)
 
         t = self.t_env.from_elements(
             [(1, 32767, -2147483648, 1, True, False, 1.0, 1.0, 'hello', '中文',
               bytearray(b'flink'), decimal.Decimal('1000000000000000000.05'),
               decimal.Decimal('1000000000000000000.05999999999999999899999999999'),
               datetime.date(2014, 9, 13), datetime.time(hour=1, minute=0, second=1),
-              timestamp_value)],
+              timestamp_value, ['hello', '中文', None], [timestamp_value], [1, 2])],
 
 Review comment:
   Test nested array?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services